Broadcast a D-Bus message whenever a user-space process crash happens.

Broadcast a D-Bus message whenever a user-space process crash happens.

BUG=none
TEST=unit test, gmerged on device and killed processes

[petkov, 2010-06-11 20:48:26]

This CL is necessary to enable http://codereview.chromium.org/2736008

[kmixter1, 2010-06-11 21:37:39]

LGTM

On Fri, Jun 11, 2010 at 1:48 PM,  <petkov@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Message:
> This CL is necessary to enable http://codereview.chromium.org/2736008
>
>
> Description:
> Broadcast a D-Bus message whenever a user-space process crash happens.
>
> BUG=none
> TEST=unit test, gmerged on device and killed processes
>
>
> Please review this at http://codereview.chromium.org/2716010/show
>
> SVN Base: ssh://git@chromiumos-git/crash.git
>
> Affected files:
>  M crash_reporter.cc
>
>
> Index: crash_reporter.cc
> diff --git a/crash_reporter.cc b/crash_reporter.cc
> index
>
951d3fae3d4ecfc96104f949b1c9cf1d3a19545b..f9dab28bc3e0dc0649ede82d630209d4158663bb
> 100644
> --- a/crash_reporter.cc
> +++ b/crash_reporter.cc
> @@ -77,6 +77,17 @@ static void CountUserCrash() {
>   s_metrics_lib.SendEnumToUMA(std::string(kCrashCounterHistogram),
>                               CRASH_KIND_USER,
>                               CRASH_KIND_MAX);
> +
> +  // Announce through D-Bus whenever a user crash happens. This is
> +  // used by the metrics daemon to log active use time between
> +  // crashes.
> +  //
> +  // This could be done more efficiently by explicit fork/exec or
> +  // using a dbus library directly. However, this should run
> +  // relatively rarely and longer term we may need to implement a
> +  // better way to do this that doesn't rely on D-Bus.
> +  if (system("/usr/bin/dbus-send --type=signal --system / "
> +             "org.chromium.CrashReporter.UserCrash")) {}
>  }
>
>  int main(int argc, char *argv[]) {
>
>
>

[petkov, 2010-06-16 20:59:14]

PTAL -- I changed the way the result status is ignored. Tested also by emerging
on arm-generic.

[kmixter1, 2010-06-16 22:54:00]

LGTM

[sosa, 2010-06-17 00:57:02]

Patched into crash-reporter - 7e602e19b3cba0a8cff21ee18e1774e319af4d07

[petkov, 2010-06-17 03:43:23]

On 2010/06/17 00:57:02, sosa wrote:
> Patched into crash-reporter - 7e602e19b3cba0a8cff21ee18e1774e319af4d07

Thank you!