Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 27160: Reverting 10251. (Closed)

Created:
11 years, 10 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

Reverting 10251. This re-lands the dependency on v8 by net (http://codereview.chromium.org/28049) It was rolled back before because of failure compiling on submodule buildbot. Marc-Antoine has updated those builders to checkout v8, so this should work now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -3 lines) Patch
M chrome/chrome.sln View 1 chunk +2 lines, -0 lines 0 comments Download
M net/build/net.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download
M net/build/net_unittests.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M net/net.sln View 6 chunks +16 lines, -0 lines 0 comments Download
M net/net.xcodeproj/project.pbxproj View 11 chunks +102 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
11 years, 10 months ago (2009-02-25 21:12:06 UTC) #1
darin (slow to review)
11 years, 10 months ago (2009-02-26 01:15:37 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698