Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 28049: Add v8 as dependency of net.... (Closed)

Created:
11 years, 10 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add v8 as dependency of net. This is needed for ProxyResolverV8, which executes proxy auto config scripts. See bug 2764. This CL has changes for {xcode, visualstudio}, but not {scons} yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10250

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -3 lines) Patch
M chrome/chrome.sln View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M net/build/net.vcproj View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M net/build/net_unittests.vcproj View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/net.sln View 1 2 3 6 chunks +16 lines, -0 lines 0 comments Download
M net/net.xcodeproj/project.pbxproj View 1 2 3 11 chunks +102 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
These diffs are pretty opaque. It may be simpler to review the _process_ I used ...
11 years, 10 months ago (2009-02-23 23:13:57 UTC) #1
darin (slow to review)
please sort the sln files using chrome/tools/build/win/sort_sln.py
11 years, 10 months ago (2009-02-23 23:17:30 UTC) #2
darin (slow to review)
complete command line: $ cd chrome $ ../third_party/python_24/python.exe tools/build/win/sort_sln.py chrome.sln do the same for net.sln
11 years, 10 months ago (2009-02-23 23:18:03 UTC) #3
eroman
Done. Thanks, that fixed it good.
11 years, 10 months ago (2009-02-23 23:28:29 UTC) #4
eroman
Updated patchset to remove the evil Websiteproperties section that VS autogenerates.
11 years, 10 months ago (2009-02-23 23:32:56 UTC) #5
darin (slow to review)
11 years, 10 months ago (2009-02-23 23:34:18 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698