Convert page contents grabbing from wide to UTF16. The current code is a bit...

chrome/browser/history/text_database_manager_unittest.cc

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/sql/connection.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/history/text_database_manager.h"
 #include "chrome/browser/history/visit_database.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Time;
 using base::TimeDelta;
 using base::TimeTicks;
 
 namespace history {
 
 namespace {
 
 const char* kURL1 = "http://www.google.com/asdf";
 const wchar_t* kTitle1 = L"Google A";
-const wchar_t* kBody1 = L"FOO page one.";
+const char* kBody1 = "FOO page one.";
 
 const char* kURL2 = "http://www.google.com/qwer";
 const wchar_t* kTitle2 = L"Google B";
-const wchar_t* kBody2 = L"FOO two.";
+const char* kBody2 = "FOO two.";
 
 const char* kURL3 = "http://www.google.com/zxcv";
 const wchar_t* kTitle3 = L"Google C";
-const wchar_t* kBody3 = L"FOO drei";
+const char* kBody3 = "FOO drei";
 
 const char* kURL4 = "http://www.google.com/hjkl";
 const wchar_t* kTitle4 = L"Google D";
-const wchar_t* kBody4 = L"FOO lalala four.";
+const char* kBody4 = "FOO lalala four.";
 
 const char* kURL5 = "http://www.google.com/uiop";
 const wchar_t* kTitle5 = L"Google cinq";
-const wchar_t* kBody5 = L"FOO page one.";
+const char* kBody5 = "FOO page one.";
 
 // This provides a simple implementation of a URL+VisitDatabase using an
 // in-memory sqlite connection. The text database manager expects to be able to
 // update the visit database to keep in sync.
 class InMemDB : public URLDatabase, public VisitDatabase {
  public:
   InMemDB() {
     EXPECT_TRUE(db_.OpenInMemory());
     CreateURLTable(false);
     InitVisitTable();
@@ skipping 25 matching lines @@
   visit_row.url_id = 1;
   visit_row.visit_time = Time::FromUTCExploded(exploded);
   visit_row.referring_visit = 0;
   visit_row.transition = 0;
   visit_row.segment_id = 0;
   visit_row.is_indexed = false;
   VisitID visit_id = visit_db->AddVisit(&visit_row);
 
   times->push_back(visit_row.visit_time);
   manager.AddPageData(GURL(kURL1), visit_row.url_id, visit_row.visit_id,
-                      visit_row.visit_time, kTitle1, kBody1);
+                      visit_row.visit_time, kTitle1, UTF8ToUTF16(kBody1));
 
   exploded.day_of_month++;
   visit_row.url_id = 2;
   visit_row.visit_time = Time::FromUTCExploded(exploded);
   visit_id = visit_db->AddVisit(&visit_row);
   times->push_back(visit_row.visit_time);
   manager.AddPageData(GURL(kURL2), visit_row.url_id, visit_row.visit_id,
-                      visit_row.visit_time, kTitle2, kBody2);
+                      visit_row.visit_time, kTitle2, UTF8ToUTF16(kBody2));
 
   exploded.day_of_month++;
   visit_row.url_id = 2;
   visit_row.visit_time = Time::FromUTCExploded(exploded);
   visit_id = visit_db->AddVisit(&visit_row);
   times->push_back(visit_row.visit_time);
   manager.AddPageData(GURL(kURL3), visit_row.url_id, visit_row.visit_id,
-                      visit_row.visit_time, kTitle3, kBody3);
+                      visit_row.visit_time, kTitle3, UTF8ToUTF16(kBody3));
 
   // Put the next ones in the next month.
   exploded.month++;
   visit_row.url_id = 2;
   visit_row.visit_time = Time::FromUTCExploded(exploded);
   visit_id = visit_db->AddVisit(&visit_row);
   times->push_back(visit_row.visit_time);
   manager.AddPageData(GURL(kURL4), visit_row.url_id, visit_row.visit_id,
-                      visit_row.visit_time, kTitle4, kBody4);
+                      visit_row.visit_time, kTitle4, UTF8ToUTF16(kBody4));
 
   exploded.day_of_month++;
   visit_row.url_id = 2;
   visit_row.visit_time = Time::FromUTCExploded(exploded);
   visit_id = visit_db->AddVisit(&visit_row);
   times->push_back(visit_row.visit_time);
   manager.AddPageData(GURL(kURL5), visit_row.url_id, visit_row.visit_id,
-                      visit_row.visit_time, kTitle5, kBody5);
+                      visit_row.visit_time, kTitle5, UTF8ToUTF16(kBody5));
 
   // Put the first one in again in the second month.
   exploded.day_of_month++;
   visit_row.url_id = 2;
   visit_row.visit_time = Time::FromUTCExploded(exploded);
   visit_id = visit_db->AddVisit(&visit_row);
   times->push_back(visit_row.visit_time);
   manager.AddPageData(GURL(kURL1), visit_row.url_id, visit_row.visit_id,
-                      visit_row.visit_time, kTitle1, kBody1);
+                      visit_row.visit_time, kTitle1, UTF8ToUTF16(kBody1));
 }
 
 bool ResultsHaveURL(const std::vector<TextDatabase::Match>& results,
                     const char* url) {
   GURL gurl(url);
   for (size_t i = 0; i < results.size(); i++) {
     if (results[i].url == gurl)
       return true;
   }
   return false;
@@ skipping 59 matching lines @@
 TEST_F(TextDatabaseManagerTest, InsertCompleteNoVisit) {
   ASSERT_TRUE(Init());
   InMemDB visit_db;
   TextDatabaseManager manager(dir_, &visit_db, &visit_db);
   ASSERT_TRUE(manager.Init(NULL));
 
   // First add one without a visit.
   const GURL url(kURL1);
   manager.AddPageURL(url, 0, 0, Time::Now());
   manager.AddPageTitle(url, kTitle1);
-  manager.AddPageContents(url, kBody1);
+  manager.AddPageContents(url, UTF8ToUTF16(kBody1));
 
   // Check that the page got added.
   QueryOptions options;
   std::vector<TextDatabase::Match> results;
   Time first_time_searched;
 
   manager.GetTextMatches(L"FOO", options, &results, &first_time_searched);
   ASSERT_EQ(1U, results.size());
   EXPECT_EQ(kTitle1, results[0].title);
 }
@@ skipping 13 matching lines @@
   visit.visit_time = Time::Now();
   visit.referring_visit = 0;
   visit.transition = PageTransition::LINK;
   visit.segment_id = 0;
   visit.is_indexed = false;
   visit_db.AddVisit(&visit);
 
   // Add a full text indexed entry for that visit.
   const GURL url(kURL2);
   manager.AddPageURL(url, visit.url_id, visit.visit_id, visit.visit_time);
-  manager.AddPageContents(url, kBody2);
+  manager.AddPageContents(url, UTF8ToUTF16(kBody2));
   manager.AddPageTitle(url, kTitle2);
 
   // Check that the page got added.
   QueryOptions options;
   std::vector<TextDatabase::Match> results;
   Time first_time_searched;
 
   manager.GetTextMatches(L"FOO", options, &results, &first_time_searched);
   ASSERT_EQ(1U, results.size());
   EXPECT_EQ(kTitle2, results[0].title);
@@ skipping 16 matching lines @@
   manager.AddPageURL(url1, 0, 0, Time::Now());
 
   // Now add a second one with a URL and title.
   GURL url2(kURL2);
   manager.AddPageURL(url2, 0, 0, Time::Now());
   manager.AddPageTitle(url2, kTitle2);
 
   // The third one has a URL and body.
   GURL url3(kURL3);
   manager.AddPageURL(url3, 0, 0, Time::Now());
-  manager.AddPageContents(url3, kBody3);
+  manager.AddPageContents(url3, UTF8ToUTF16(kBody3));
 
   // Expire stuff very fast. This assumes that the time between the first
   // AddPageURL and this line is less than the expiration time (20 seconds).
   TimeTicks added_time = TimeTicks::Now();
   TimeTicks expire_time = added_time + TimeDelta::FromSeconds(5);
   manager.FlushOldChangesForTime(expire_time);
 
   // Do a query, nothing should be added yet.
   QueryOptions options;
   std::vector<TextDatabase::Match> results;
@@ skipping 46 matching lines @@
   manager.AddPageTitle(url, L"Some unique title");
   Time first_time_searched;
   QueryOptions options;
   std::vector<TextDatabase::Match> results;
   manager.GetTextMatches(L"unique", options, &results, &first_time_searched);
   EXPECT_EQ(1U, results.size());
   manager.GetTextMatches(L"chocolate", options, &results, &first_time_searched);
   EXPECT_EQ(0U, results.size());
 
   // Now add the body, which should be queryable.
-  manager.AddPageContents(url, L"Very awesome body");
+  manager.AddPageContents(url, UTF8ToUTF16("Very awesome body"));
   manager.GetTextMatches(L"awesome", options, &results, &first_time_searched);
   EXPECT_EQ(1U, results.size());
 
   // Adding the body will actually copy the title from the URL table rather
   // than the previously indexed row (we made them not match above). This isn't
   // necessarily what we want, but it's how it's implemented, and we don't want
   // to regress it.
   manager.GetTextMatches(L"chocolate", options, &results, &first_time_searched);
   EXPECT_EQ(1U, results.size());
 }
@@ skipping 151 matching lines @@
   EXPECT_TRUE(ResultsHaveURL(results, kURL2));
   EXPECT_TRUE(ResultsHaveURL(results, kURL1));
 
   // Try to query some more, there should be no results.
   options.end_time = first_time_searched;
   manager.GetTextMatches(L"FOO", options, &results, &first_time_searched);
   EXPECT_EQ(0U, results.size());
 }
 
 }  // namespace history