Issue 270100: Fix clearing render targets in D3D if there...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270100: Fix clearing render targets in D3D if there... (Closed)

Created:
11 years, 2 months ago by gman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fix clearing render targets in D3D if there is no associated depth buffer. There's something I don't get here. I thought the dimensions of the depth-stencil and the render target had to match but apparently they don't?

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -20 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	DEPS_chrome	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	DEPS_gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	core/win/d3d9/renderer_d3d9.cc	View	1	2 chunks	+10 lines, -16 lines	0 comments	Download
M	tests/selenium/javascript_unit_test_list.txt	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/selenium/selenium.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/selenium/tests/render-target-clear-test.html	View		1 chunk	+156 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

11 years, 2 months ago (2009-10-14 03:07:44 UTC) #2

LGTM. There's a reference screenshot in the CL right? I don't know if binaries
show up on codereview.

Expand Messages | Collapse Messages