Issue 270066: Step 2 in porting disk cache to using FilePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270066: Step 2 in porting disk cache to using FilePath. (Closed)

Created:
11 years, 2 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Step 2 in porting disk cache to using FilePath. BUG=24444 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28742

Patch Set 1 #

Total comments: 1

Patch Set 2 : deprecated #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -19 lines)			Patch
M	base/platform_file.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	base/platform_file_posix.cc	View		3 chunks	+10 lines, -7 lines	0 comments	Download
M	base/platform_file_win.cc	View		3 chunks	+9 lines, -3 lines	0 comments	Download
M	net/disk_cache/block_files_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/entry_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/file.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	net/disk_cache/file_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/file_win.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	net/disk_cache/mapped_file_posix.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	net/disk_cache/mapped_file_win.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

11 years, 2 months ago (2009-10-12 19:52:48 UTC) #2

LGTM

http://codereview.chromium.org/270066/diff/1/2
File base/platform_file.h (right):

http://codereview.chromium.org/270066/diff/1/2#newcode48
Line 48: // Obsolete.
nit: I thought we were using deprecated :)

Expand Messages | Collapse Messages