Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: base/platform_file_win.cc

Issue 270066: Step 2 in porting disk cache to using FilePath. (Closed)
Patch Set: deprecated Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/platform_file_posix.cc ('k') | net/disk_cache/block_files_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/platform_file.h" 5 #include "base/platform_file.h"
6 6
7 #include "base/file_path.h"
7 #include "base/logging.h" 8 #include "base/logging.h"
8 9
9 namespace base { 10 namespace base {
10 11
11 PlatformFile CreatePlatformFile(const std::wstring& name, 12 PlatformFile CreatePlatformFile(const FilePath& name,
12 int flags, 13 int flags,
13 bool* created) { 14 bool* created) {
14 DWORD disposition = 0; 15 DWORD disposition = 0;
15 16
16 if (flags & PLATFORM_FILE_OPEN) 17 if (flags & PLATFORM_FILE_OPEN)
17 disposition = OPEN_EXISTING; 18 disposition = OPEN_EXISTING;
18 19
19 if (flags & PLATFORM_FILE_CREATE) { 20 if (flags & PLATFORM_FILE_CREATE) {
20 DCHECK(!disposition); 21 DCHECK(!disposition);
21 disposition = CREATE_NEW; 22 disposition = CREATE_NEW;
(...skipping 25 matching lines...) Expand all
47 DWORD create_flags = 0; 48 DWORD create_flags = 0;
48 if (flags & PLATFORM_FILE_ASYNC) 49 if (flags & PLATFORM_FILE_ASYNC)
49 create_flags |= FILE_FLAG_OVERLAPPED; 50 create_flags |= FILE_FLAG_OVERLAPPED;
50 if (flags & PLATFORM_FILE_TEMPORARY) 51 if (flags & PLATFORM_FILE_TEMPORARY)
51 create_flags |= FILE_ATTRIBUTE_TEMPORARY; 52 create_flags |= FILE_ATTRIBUTE_TEMPORARY;
52 if (flags & PLATFORM_FILE_HIDDEN) 53 if (flags & PLATFORM_FILE_HIDDEN)
53 create_flags |= FILE_ATTRIBUTE_HIDDEN; 54 create_flags |= FILE_ATTRIBUTE_HIDDEN;
54 if (flags & PLATFORM_FILE_DELETE_ON_CLOSE) 55 if (flags & PLATFORM_FILE_DELETE_ON_CLOSE)
55 create_flags |= FILE_FLAG_DELETE_ON_CLOSE; 56 create_flags |= FILE_FLAG_DELETE_ON_CLOSE;
56 57
57 HANDLE file = CreateFile(name.c_str(), access, sharing, NULL, disposition, 58 HANDLE file = CreateFile(name.value().c_str(), access, sharing, NULL,
58 create_flags, NULL); 59 disposition, create_flags, NULL);
59 60
60 if ((flags & PLATFORM_FILE_OPEN_ALWAYS) && created && 61 if ((flags & PLATFORM_FILE_OPEN_ALWAYS) && created &&
61 INVALID_HANDLE_VALUE != file) { 62 INVALID_HANDLE_VALUE != file) {
62 *created = (ERROR_ALREADY_EXISTS != GetLastError()); 63 *created = (ERROR_ALREADY_EXISTS != GetLastError());
63 } 64 }
64 65
65 return file; 66 return file;
66 } 67 }
67 68
69 PlatformFile CreatePlatformFile(const std::wstring& name, int flags,
70 bool* created) {
71 return CreatePlatformFile(FilePath::FromWStringHack(name), flags, created);
72 }
73
68 bool ClosePlatformFile(PlatformFile file) { 74 bool ClosePlatformFile(PlatformFile file) {
69 return (CloseHandle(file) == 0); 75 return (CloseHandle(file) == 0);
70 } 76 }
71 77
72 } // namespace disk_cache 78 } // namespace disk_cache
OLDNEW
« no previous file with comments | « base/platform_file_posix.cc ('k') | net/disk_cache/block_files_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698