Issue 2693001: Cleanup style nits in metrics daemon.

Issue 2693001: Cleanup style nits in metrics daemon. (Closed)

Created:
10 years, 6 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
petkov, tfarina

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/metrics.git

Visibility:
Public.

Description

Cleanup style nits in metrics daemon. - Remove trailing spaces. - Convert 'char *' to 'char*' - Fix other minor style nits - Many of these issues were pointed out by tfarina. BUG=none TEST=Checked that it compiles and passes tests. Committed: http://git.chromium.org/cgi-bin/gitweb.cgi?p=metrics.git;a=commit;h=13d0c48fad1ce0f7a4e7c3fa61795566c805f4d2

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix nit #

Patch Set 3 : Fix more nits from tfarina #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
M	metrics_daemon.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	metrics_daemon_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	metrics_library.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	metrics_library.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	syslog_parser.sh	View		3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

petkov

Thanks for fixing these. LGTM w/ a nit. http://codereview.chromium.org/2693001/diff/1/4 File metrics_library.cc (right): http://codereview.chromium.org/2693001/diff/1/4#newcode28 metrics_library.cc:28: static ...

10 years, 6 months ago (2010-06-04 21:50:52 UTC) #2

tfarina

Thanks for the cleanup David! http://codereview.chromium.org/2693001/diff/1/4 File metrics_library.cc (right): http://codereview.chromium.org/2693001/diff/1/4#newcode23 metrics_library.cc:23: using namespace std; ops, ...

10 years, 6 months ago (2010-06-04 21:52:18 UTC) #3

davidjames

10 years, 6 months ago (2010-06-04 22:00:22 UTC) #5

http://codereview.chromium.org/2693001/diff/1/4
File metrics_library.cc (right):

http://codereview.chromium.org/2693001/diff/1/4#newcode23
metrics_library.cc:23: using namespace std;
On 2010/06/04 21:52:18, tfarina wrote:
> ops, this is forbidden by the style guide. :/

Fixed. Turns out that all we were using was std::string so I just imported that
one only.

http://codereview.chromium.org/2693001/diff/1/4#newcode28
metrics_library.cc:28: static const char* kProgramName = "libmetrics";
On 2010/06/04 21:50:52, petkov wrote:
> Switch to []
> 

Done.

http://codereview.chromium.org/2693001/diff/1/4#newcode28
metrics_library.cc:28: static const char* kProgramName = "libmetrics";
On 2010/06/04 21:52:18, tfarina wrote:
> could you change this to kProgramName[] = "..."?

Doubly done.

http://codereview.chromium.org/2693001/diff/1/5
File metrics_library.h (right):

http://codereview.chromium.org/2693001/diff/1/5#newcode83
metrics_library.h:83: #endif /* METRICS_LIBRARY_H_ */
On 2010/06/04 21:52:18, tfarina wrote:
> since you are here, please, could you write this as:
> // METRICS_LIBRARY_H_
> 
> ?

Done.

Expand Messages | Collapse Messages