Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: metrics_library.cc

Issue 2693001: Cleanup style nits in metrics daemon. (Closed) Base URL: ssh://git@chromiumos-git/metrics.git
Patch Set: Fix more nits from tfarina Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « metrics_library.h ('k') | syslog_parser.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: metrics_library.cc
diff --git a/metrics_library.cc b/metrics_library.cc
index 6ec72262d017395dddc15ecb062f70a0124510b0..e4087ef37ae874a7d3b1d223a0cdd7cd18d9d40d 100644
--- a/metrics_library.cc
+++ b/metrics_library.cc
@@ -20,12 +20,12 @@ static const char kUMAEventsPath[] =
"/var/log/metrics/uma-events";
static const int32_t kBufferSize = 1024;
-using namespace std;
+using std::string;
// TODO(sosa@chromium.org) - use Chromium logger instead of stderr
static void PrintError(const char* message, const char* file,
int code) {
- static const char *kProgramName = "libmetrics";
+ static const char kProgramName[] = "libmetrics";
if (code == 0) {
fprintf(stderr, "%s: %s\n", kProgramName, message);
} else if (file == NULL) {
@@ -113,7 +113,7 @@ void MetricsLibrary::Init() {
}
bool MetricsLibrary::SendToAutotest(const string& name, int value) {
- FILE *autotest_file = fopen(kAutotestPath, "a+");
+ FILE* autotest_file = fopen(kAutotestPath, "a+");
if (autotest_file == NULL) {
PrintError("fopen", kAutotestPath, errno);
return false;
« no previous file with comments | « metrics_library.h ('k') | syslog_parser.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698