Issue 269103: Implement chrome.browserAction.setIcon({path:...});

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269103: Implement chrome.browserAction.setIcon({path:...}); (Closed)

Created:
11 years, 2 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement chrome.browserAction.setIcon({path:...}); BUG=22575 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29495

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -0 lines)			Patch
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/resources/extension_process_bindings.js	View	2 chunks	+25 lines, -0 lines	1 comment	Download
A	chrome/test/data/extensions/samples/set_icon_path/background.html	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/samples/set_icon_path/icon1.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/samples/set_icon_path/icon2.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/samples/set_icon_path/icon3.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/samples/set_icon_path/icon4.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/samples/set_icon_path/icon5.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/samples/set_icon_path/manifest.json	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 2 months ago (2009-10-16 19:06:05 UTC) #2

LGTM. Kinda cool that it's doable in javascript like that.

http://codereview.chromium.org/269103/diff/1/3
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/269103/diff/1/3#newcode359
Line 359: canvas.width = 19;
isn't it 21 now?

Expand Messages | Collapse Messages