Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(750)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/samples/set_icon_path/manifest.json
Issue
269103
:
Implement chrome.browserAction.setIcon({path:...}); (Closed)
Patch Set:
Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/common/extensions/api/extension_api.json
chrome/renderer/resources/extension_process_bindings.js
chrome/test/data/extensions/samples/set_icon_path/background.html
chrome/test/data/extensions/samples/set_icon_path/icon1.png
chrome/test/data/extensions/samples/set_icon_path/icon2.png
chrome/test/data/extensions/samples/set_icon_path/icon3.png
chrome/test/data/extensions/samples/set_icon_path/icon4.png
chrome/test/data/extensions/samples/set_icon_path/icon5.png
chrome/test/data/extensions/samples/set_icon_path/manifest.json
View unified diff
|
Download patch
« chrome/renderer/resources/extension_process_bindings.js
('K') |
« chrome/test/data/extensions/samples/set_icon_path/icon5.png
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"name": "A browser action with no icon that makes the page red",
3
"version": "1.0",
4
"background_page": "background.html",
5
"permissions": [
6
"tabs", "http://*/*"
7
],
8
"browser_action": {
9
"name": "Make this page red"
10
}
11
}
OLD
NEW
« chrome/renderer/resources/extension_process_bindings.js
('K') |
« chrome/test/data/extensions/samples/set_icon_path/icon5.png
('k') |
no next file »
|
no next file with comments »
Issue 269103: Implement chrome.browserAction.setIcon({path:...}); (Closed)
Created 11 years, 2 months ago by Aaron Boodman
Modified 9 years, 6 months ago
Reviewers: Matt Perry
Base URL:
Comments: 1
This is Rietveld
408576698
Chromium Code Reviews
Issue 269103:
Implement chrome.browserAction.setIcon({path:...}); (Closed)
