Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2666001: Optimize calls to evals. Most of the time there is no reason to... (Closed)

Created:
10 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Optimize calls to evals. Most of the time there is no reason to perform a context lookup in the runtime system for the 'eval' function. Instead load the 'eval' function from the global context in generated code if it is not shadowed. Will port to other platforms as a separate change. Committed: http://code.google.com/p/v8/source/detail?r=4794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -20 lines) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +45 lines, -5 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +39 lines, -14 lines 0 comments Download
M test/mjsunit/eval.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 6 months ago (2010-06-04 08:22:43 UTC) #1
Erik Corry
10 years, 6 months ago (2010-06-04 10:13:03 UTC) #2
STV!

Powered by Google App Engine
This is Rietveld 408576698