Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 266043: Add pymox, fixed non-deterministic pprint.pformat output expectation.... (Closed)

Created:
11 years, 2 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

Add pymox, fixed non-deterministic pprint.pformat output expectation. pymox auto-checkout never really worked well so check-in pymox directly. pprint.pformat is non-determinist in one test. Worked around the issue. TEST=unit tests BUG=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3913 lines, -34 lines) Patch
M tests/gclient_test.py View 3 chunks +18 lines, -2 lines 1 comment Download
A tests/pymox/COPYING View 1 chunk +202 lines, -0 lines 0 comments Download
A tests/pymox/MANIFEST.in View 1 chunk +5 lines, -0 lines 0 comments Download
A tests/pymox/README View 1 chunk +56 lines, -0 lines 0 comments Download
A tests/pymox/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/pymox/mox.py View 1 chunk +1643 lines, -0 lines 0 comments Download
A tests/pymox/mox_test.py View 1 chunk +1708 lines, -0 lines 0 comments Download
A tests/pymox/mox_test_helper.py View 1 chunk +76 lines, -0 lines 0 comments Download
A tests/pymox/setup.py View 1 chunk +14 lines, -0 lines 0 comments Download
A tests/pymox/stubout.py View 1 chunk +142 lines, -0 lines 0 comments Download
A tests/pymox/stubout_test.py View 1 chunk +47 lines, -0 lines 0 comments Download
A tests/pymox/stubout_testee.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/super_mox.py View 1 chunk +1 line, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 2 months ago (2009-10-09 21:05:30 UTC) #1
Mandeep Singh Baines
lgtm One suggestion to consider but its just a nit. http://codereview.chromium.org/266043/diff/1/3 File tests/gclient_test.py (right): http://codereview.chromium.org/266043/diff/1/3#newcode42 ...
11 years, 2 months ago (2009-10-09 22:28:35 UTC) #2
M-A Ruel
11 years, 2 months ago (2009-10-09 22:41:46 UTC) #3
btw, this class is a copy from pymox with what I needed, I'l try to
upstream.
So I'd rather do like pymox and not pprint.

On Oct 9, 2009 6:28 PM, <msb@chromium.org> wrote:

lgtm

One suggestion to consider but its just a nit.


http://codereview.chromium.org/266043/diff/1/3
File tests/gclient_test.py (right):

http://codereview.chromium.org/266043/diff/1/3#newcode42
Line 42: return '<sequence or map containing \'%s\'>' % str(self._keys)
An alternative might be to strip white-space and then compare.
Or use repr() instead of pprint. I used pprint but because I wanted the
file to be easily parseable by humans. But sucks that its not
deterministic. So maybe repr() is better.

http://codereview.chromium.org/266043

Powered by Google App Engine
This is Rietveld 408576698