Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: src/native_client/src/trusted/service_runtime/sel_ldr.h

Issue 2659002: Remove thread refcount and remove NaClAppDtor() (Closed)
Patch Set: Fix Gyp build Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/native_client/src/trusted/service_runtime/sel_ldr.h
diff --git a/src/native_client/src/trusted/service_runtime/sel_ldr.h b/src/native_client/src/trusted/service_runtime/sel_ldr.h
index 578937af32972d785d2011af77b78580c0001ee6..cb04d7989f75f8ec537513ae658971482e40ab82 100644
--- a/src/native_client/src/trusted/service_runtime/sel_ldr.h
+++ b/src/native_client/src/trusted/service_runtime/sel_ldr.h
@@ -99,13 +99,6 @@ struct NaClApp {
* Read-only after load, so accesses do not require locking.
*/
uintptr_t mem_start;
- /*
- * Flag to remember whether guard pages may be present. If true, then
- * on tear down, NaClTeardownMprotectGuards should be invoked.
- *
- * This will probably go away when we remove the NaClAppDtor.
- */
- int guard_pages_initialized;
#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_x86 && NACL_BUILD_SUBARCH == 32 && __PIC__
uintptr_t pcrel_thunk;
@@ -240,18 +233,6 @@ void NaClAppIncrVerbosity(void);
int NaClAppCtor(struct NaClApp *nap) NACL_WUR;
-/* DEPRECATED */
-void NaClAppDtor(struct NaClApp *nap);
-/*
- * TODO(bsy): remove NaClAppDtor. This teardown/cleanup activity
- * is better left to the OS.
- *
- * We expect *one* NaClApp per process, and having multiple NaClApp
- * constructed / used is not supported (though some tests do this).
- */
-
-void NaClAppFreeAllMemory(struct NaClApp *nap);
-
/*
* Loads a NaCl ELF file into memory in preparation for running it.
*

Powered by Google App Engine
This is Rietveld 408576698