Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/native_client/src/trusted/service_runtime/sel_ldr_test.cc

Issue 2659002: Remove thread refcount and remove NaClAppDtor() (Closed)
Patch Set: Fix Gyp build Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/native_client/src/trusted/service_runtime/sel_ldr_test.cc
diff --git a/src/native_client/src/trusted/service_runtime/sel_ldr_test.cc b/src/native_client/src/trusted/service_runtime/sel_ldr_test.cc
index 6c8b7e6e126d72cb807a7c904263b7c840717457..45043e681300f1433b6b065d0c57c6ff0ee403e1 100644
--- a/src/native_client/src/trusted/service_runtime/sel_ldr_test.cc
+++ b/src/native_client/src/trusted/service_runtime/sel_ldr_test.cc
@@ -79,8 +79,6 @@ TEST_F(SelLdrTest, DescTable) {
// never set a desc at pos 10
ret_desc = NaClGetDesc(&app, 10);
ASSERT_TRUE(NULL == ret_desc);
-
- NaClAppDtor(&app);
Cliff L. Biffle 2010/06/08 00:14:24 Hm, tests are actually the one context where I'd e
}
// create service socket
@@ -100,7 +98,6 @@ TEST_F(SelLdrTest, CreateServiceSocket) {
ASSERT_TRUE(NULL != app.service_port);
ASSERT_TRUE(NULL != app.service_address);
- NaClAppDtor(&app);
NaClNrdAllModulesFini();
}
@@ -133,10 +130,4 @@ TEST_F(SelLdrTest, ThreadTableTest) {
NaClRemoveThread(&app, 0);
ASSERT_EQ(2, app.num_threads);
-
- // NaClAppDtor is deprecated and will be removed soon; this test
- // should be refactored so that NaClAppCtor is called at most once
- // per run.
-
- // NaClAppDtor(&app);
}
« no previous file with comments | « src/native_client/src/trusted/service_runtime/sel_ldr.c ('k') | src/native_client/src/trusted/service_runtime/sel_main.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698