src/native_client/src/trusted/service_runtime/nacl_syscall_common.c - Issue 2659002: Remove thread refcount and remove NaClAppDtor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/native_client/src/trusted/service_runtime/nacl_syscall_common.c

Issue 2659002: Remove thread refcount and remove NaClAppDtor() (Closed)

Patch Set: Fix Gyp build Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/native_client/src/trusted/service_runtime/nacl_app_thread.c ('k') | src/native_client/src/trusted/service_runtime/sel_addrspace.h » ('j') | src/native_client/src/trusted/service_runtime/sel_ldr_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/native_client/src/trusted/service_runtime/nacl_syscall_common.c

diff --git a/src/native_client/src/trusted/service_runtime/nacl_syscall_common.c b/src/native_client/src/trusted/service_runtime/nacl_syscall_common.c

index 3c8507ac33e3f7abf45cfe35f7a1d32932015c10..8e74a868f6f93fb261a45827765c37e363900b78 100644

--- a/src/native_client/src/trusted/service_runtime/nacl_syscall_common.c

+++ b/src/native_client/src/trusted/service_runtime/nacl_syscall_common.c

@@ -103,8 +103,8 @@ void NaClSysCommonThreadSuicide(struct NaClAppThread *natp) {

NaClXCondVarBroadcast(&nap->threads_cv);

NaClLog(3, " unlocking thread table\n");

NaClXMutexUnlock(&nap->threads_mu);

- NaClLog(3, " decref'ing thread object (from count %d)\n", natp->refcount);

- NaClAppThreadDecRef(natp);

+ NaClLog(3, " freeing thread object\n");

+ NaClAppThreadDtor(natp);

NaClLog(3, " NaClThreadExit\n");

NaClThreadExit(); /* should not return */

NaClLog(LOG_ERROR, "INCONCEIVABLE!\n");