Get rid of DISALLOW_EVIL_CONSTRUCTORS macro usage in our code base.

Get rid of DISALLOW_EVIL_CONSTRUCTORS macro usage in our code base.

TODO: Fix the remaining usages in third_party libraries and get rid of the macro in question.

BUG=None
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49032

[tfarina, 2010-06-06 14:08:55]

Please, take a look.

Note, we have this macro in the following projects yet, but I think it's ok,
since they are in third_party any way.
third_party/cld/
third_party/libjingle/
third_party/tcmalloc/

[Paweł Hajdan Jr., 2010-06-06 14:17:03]

LGTM, thanks for this nice cleanup.

Yeah, in third_party code it's fine, and we don't want to fork it too much.

[tfarina, 2010-06-06 23:39:16]

On 2010/06/06 14:17:03, Paweł Hajdan Jr. wrote:
> LGTM, thanks for this nice cleanup.
> 
> Yeah, in third_party code it's fine, and we don't want to fork it too much.

Pawel, I added the macro back, and added a comment with a TODO to me to fix it,
also I rewrote the description of the CL.

The trybots triggered the issue that some of third_party libraries (like
libjingle and hunspell) still depends on this macro, because they are importing
base/basictypes.h.

If the trybots passes, I will go ahead and commit.

[tfarina, 2010-06-07 02:09:03]

Committing now...