Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: gpu/command_buffer/common/types.h

Issue 2657005: Get rid of DISALLOW_EVIL_CONSTRUCTORS macro usage in our code base. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: added the macro back Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gfx/icon_util_unittest.cc ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file contains cross-platform basic type definitions 5 // This file contains cross-platform basic type definitions
6 6
7 #ifndef GPU_COMMAND_BUFFER_COMMON_TYPES_H_ 7 #ifndef GPU_COMMAND_BUFFER_COMMON_TYPES_H_
8 #define GPU_COMMAND_BUFFER_COMMON_TYPES_H_ 8 #define GPU_COMMAND_BUFFER_COMMON_TYPES_H_
9 9
10 #include <build/build_config.h> 10 #include <build/build_config.h>
11 #if !defined(COMPILER_MSVC) 11 #if !defined(COMPILER_MSVC)
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 #else 62 #else
63 typedef unsigned long long uint64; 63 typedef unsigned long long uint64;
64 #endif 64 #endif
65 65
66 // A macro to disallow the copy constructor and operator= functions 66 // A macro to disallow the copy constructor and operator= functions
67 // This should be used in the private: declarations for a class 67 // This should be used in the private: declarations for a class
68 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ 68 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
69 TypeName(const TypeName&); \ 69 TypeName(const TypeName&); \
70 void operator=(const TypeName&) 70 void operator=(const TypeName&)
71 71
72 // An older, deprecated, politically incorrect name for the above.
73 #define DISALLOW_EVIL_CONSTRUCTORS(TypeName) DISALLOW_COPY_AND_ASSIGN(TypeName)
74
75 // A macro to disallow all the implicit constructors, namely the 72 // A macro to disallow all the implicit constructors, namely the
76 // default constructor, copy constructor and operator= functions. 73 // default constructor, copy constructor and operator= functions.
77 // 74 //
78 // This should be used in the private: declarations for a class 75 // This should be used in the private: declarations for a class
79 // that wants to prevent anyone from instantiating it. This is 76 // that wants to prevent anyone from instantiating it. This is
80 // especially useful for classes containing only static methods. 77 // especially useful for classes containing only static methods.
81 #define DISALLOW_IMPLICIT_CONSTRUCTORS(TypeName) \ 78 #define DISALLOW_IMPLICIT_CONSTRUCTORS(TypeName) \
82 TypeName(); \ 79 TypeName(); \
83 DISALLOW_COPY_AND_ASSIGN(TypeName) 80 DISALLOW_COPY_AND_ASSIGN(TypeName)
84 81
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 typedef uint16_t Uint16; 184 typedef uint16_t Uint16;
188 typedef int32_t Int32; 185 typedef int32_t Int32;
189 typedef uint32_t Uint32; 186 typedef uint32_t Uint32;
190 #endif 187 #endif
191 188
192 typedef std::string String; 189 typedef std::string String;
193 190
194 } // namespace gpu 191 } // namespace gpu
195 192
196 #endif // GPU_COMMAND_BUFFER_COMMON_TYPES_H_ 193 #endif // GPU_COMMAND_BUFFER_COMMON_TYPES_H_
OLDNEW
« no previous file with comments | « gfx/icon_util_unittest.cc ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698