add c++ version of the firmware utilities

c++ version of the firmware utilities.

This was translated from the original python scripts.
For more information (including the test procedure) please refer to:

 (gpio_setup) http://codereview.chromium.org/2421006
 (reboot_mode) http://codereview.chromium.org/2320003

[vb, 2010-06-07 21:12:54]

Hung-Te, great job, even lint had nothing to complaint about :)

On top of the few comments below I think what's missing is the description of
the testing procedures and history behind this change.

Please cross reference the original CLs in this CL description so that there is
some continuity and information on how to test these modules is they need to be
changed.

Also, I don't think it is worth keeping the .py files here, but if you do - at
the very least add a Readme.txt describing what goes on on this directory (it
will also help when new firmware util source files are added).

ccing mdhayter as he will be adding more files to this directory.

http://codereview.chromium.org/2656004/diff/1/2
File Makefile (right):

http://codereview.chromium.org/2656004/diff/1/2#newcode15
Makefile:15: @rm -f $(TARGETS) *.o *~
since this make file does not cause .* files to be generated there is no point
in including them in the `clean' target.

http://codereview.chromium.org/2656004/diff/1/3
File gpio_setup.cc (right):

http://codereview.chromium.org/2656004/diff/1/3#newcode88
gpio_setup.cc:88: (sizeof(GPIO_SIGNAL_TYPES)/sizeof(GPIO_SIGNAL_TYPES[0]) - 1)
- GPIO_SIGNAL_TYPE_MIN) would be clearer than -1)

[Hung-Te, 2010-06-07 22:03:00]

I've made changes according to the suggestions, except the TYPE_MIN one
(described below).

http://codereview.chromium.org/2656004/diff/1/2
File Makefile (right):

http://codereview.chromium.org/2656004/diff/1/2#newcode15
Makefile:15: @rm -f $(TARGETS) *.o *~
On 2010/06/07 21:12:54, vb wrote:
> since this make file does not cause .* files to be generated there is no point
> in including them in the `clean' target.
> 

Done.

http://codereview.chromium.org/2656004/diff/1/3
File gpio_setup.cc (right):

http://codereview.chromium.org/2656004/diff/1/3#newcode88
gpio_setup.cc:88: (sizeof(GPIO_SIGNAL_TYPES)/sizeof(GPIO_SIGNAL_TYPES[0]) - 1)
On 2010/06/07 21:12:54, vb wrote:
> - GPIO_SIGNAL_TYPE_MIN) would be clearer than -1)
 I think this must be one. The macro here is the 'max (possible) value' instead
of 'valid size', so if we change 1 to MIN and someone changed MIN to 2, then the
max would go wrong.

 The real meaning of N-1 here refers to 'get max valid index value of a
zero-base array', where sizeof(N)/sizeof(N[0]) gets "valid size (max+1)" so max
should be "size-1".

 I will add some comments in the code to highlight it's not MIN.

[vb, 2010-06-07 22:22:27]

LGTM

thank you for addressing my comments.

[resend from the proper source address]

On Mon, Jun 7, 2010 at 3:03 PM,  <hungte@chromium.org> wrote:
> I've made changes according to the suggestions, except the TYPE_MIN one
> (described below).
>
>
> http://codereview.chromium.org/2656004/diff/1/2
> File Makefile (right):
>
> http://codereview.chromium.org/2656004/diff/1/2#newcode15
> Makefile:15: @rm -f $(TARGETS) *.o *~
> On 2010/06/07 21:12:54, vb wrote:
>>
>> since this make file does not cause .* files to be generated there is
>
> no point
>>
>> in including them in the `clean' target.
>
>
> Done.
>
> http://codereview.chromium.org/2656004/diff/1/3
> File gpio_setup.cc (right):
>
> http://codereview.chromium.org/2656004/diff/1/3#newcode88
> gpio_setup.cc:88:
> (sizeof(GPIO_SIGNAL_TYPES)/sizeof(GPIO_SIGNAL_TYPES[0]) - 1)
> On 2010/06/07 21:12:54, vb wrote:
>>
>> - GPIO_SIGNAL_TYPE_MIN) would be clearer than -1)
>
>  I think this must be one. The macro here is the 'max (possible) value'
> instead of 'valid size', so if we change 1 to MIN and someone changed
> MIN to 2, then the max would go wrong.
>
>  The real meaning of N-1 here refers to 'get max valid index value of a
> zero-base array', where sizeof(N)/sizeof(N[0]) gets "valid size (max+1)"
> so max should be "size-1".
>
>  I will add some comments in the code to highlight it's not MIN.
>
> http://codereview.chromium.org/2656004/show
>



--
Vadim Bendebury (mailto:vbendeb@google.com)
Google ChromeOS - (650) 253-7486



-- 
Vadim Bendebury (mailto:vbendeb@google.com)
Google ChromeOS - (650) 253-7486