Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2421006: A script to create ACPI based GPIO mapping. (Closed)

Created:
10 years, 6 months ago by vb
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, dhendrix
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

A script to create ACPI based GPIO mapping. See the doc string for theory of operation. Testing ======= On an ST8 system with the Insyde BIOS implementing a mock ACPI device: localhost tmp # ./gpio_setup.py gpio_setup.py: could not find GPIO PCI device 0000:00:1f.0 localhost tmp # modprobe nm10_gpio.ko localhost tmp # ./gpio_setup.py gpio_setup.py: no gpio mapping found. Is ACPI driver installed? localhost tmp # modprobe chromeos_acpi localhost tmp # ./gpio_setup.py gpio_setup.py: /home/gpio does not exist localhost tmp # mkdir /home/gpio localhost tmp # ./gpio_setup.py localhost tmp # ls /home/gpio debug_header_0 debug_header_1 debug_header_2 debug_header_3 developer_switch recovery_button write_protect localhost tmp # cat /home/gpio/developer_switch 1 # At this point press and hold the developer button localhost tmp # cat /home/gpio/developer_switch 0 # At this point release the developer button localhost tmp # cat /home/gpio/developer_switch 1 localhost tmp # ./gpio_setup.py --help Usage: gpio_setup.py [options] Options: -h, --help show this help message and exit --symlink_root=SYMLINK_ROOT --pci_address=PCI_ADDRESS --acpi_root=ACPI_ROOT localhost tmp # ./gpio_setup.py --acpi_root=/tmp/xuz gpio_setup.py: no gpio mapping found. Is ACPI driver installed? localhost tmp # ./gpio_setup.py --pci_address=0.1.2.3 gpio_setup.py: could not find GPIO PCI device 0.1.2.3 localhost tmp # ./gpio_setup.py --symlink_root=/tmp/xyz gpio_setup.py: /tmp/xyz does not exist

Patch Set 1 : Prepared for review. #

Total comments: 4

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -0 lines) Patch
A src/platform/utils/gpio_setup.py View 1 1 chunk +230 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vb
10 years, 6 months ago (2010-06-02 01:41:36 UTC) #1
vb
Hung Te, please have a look as we discussed.
10 years, 6 months ago (2010-06-02 17:30:48 UTC) #2
Hung-Te
http://codereview.chromium.org/2421006/diff/4001/5001 File src/platform/utils/gpio_setup.py (right): http://codereview.chromium.org/2421006/diff/4001/5001#newcode116 src/platform/utils/gpio_setup.py:116: dir = os.path.dirname(f) changing built-in names like 'dir' may ...
10 years, 6 months ago (2010-06-02 19:15:51 UTC) #3
vb
Hung-Te, I addressed your comments, please look again. http://codereview.chromium.org/2421006/diff/4001/5001 File src/platform/utils/gpio_setup.py (right): http://codereview.chromium.org/2421006/diff/4001/5001#newcode116 src/platform/utils/gpio_setup.py:116: dir ...
10 years, 6 months ago (2010-06-02 20:51:49 UTC) #4
Hung-Te
10 years, 6 months ago (2010-06-02 21:12:40 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698