Atheros patch to support ath3k BT device.

Atheros patch to support ath3k BT device.

These changes come from vipin.mehta@atheros.com, after being
tested at Atheros.

[Sam Leffler, 2010-06-04 18:01:18]

Only did a cursory scan of the actual code.  You decide whether to fix directly
or kick back to submitter.

http://codereview.chromium.org/2649001/diff/1/2
File chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c (right):

http://codereview.chromium.org/2649001/diff/1/2#newcode168
chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c:168:
sprintf(path,"%s/%xcoex/",CONFIG_PATH,Rom_Version);
use snprintf

http://codereview.chromium.org/2649001/diff/1/2#newcode186
chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c:186:
sprintf(config_path,"%s%s",path,PsFileName);
snprintf

http://codereview.chromium.org/2649001/diff/1/2#newcode215
chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c:215:
sprintf(config_path,"%s%s",path,patchFileName);
snprintf

http://codereview.chromium.org/2649001/diff/1/6
File drivers/bluetooth/hci_ath.c (right):

http://codereview.chromium.org/2649001/diff/1/6#newcode346
drivers/bluetooth/hci_ath.c:346: BT_ERR("HCIATH protocol registration failed");
include err in msg unless it gets displayed somewhere else

[vb, 2010-06-05 01:00:27]

Sam, I fixed the problems you mentioned, please have another look.

I will also communicate to Atheros guys that they have to comply with kernel
coding standards.

http://codereview.chromium.org/2649001/diff/1/2
File chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c (right):

http://codereview.chromium.org/2649001/diff/1/2#newcode168
chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c:168:
sprintf(path,"%s/%xcoex/",CONFIG_PATH,Rom_Version);
On 2010/06/04 18:01:18, Sam Leffler wrote:
> use snprintf

Done.

http://codereview.chromium.org/2649001/diff/1/2#newcode186
chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c:186:
sprintf(config_path,"%s%s",path,PsFileName);
On 2010/06/04 18:01:18, Sam Leffler wrote:
> snprintf

Done.

http://codereview.chromium.org/2649001/diff/1/2#newcode215
chromeos/drivers/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c:215:
sprintf(config_path,"%s%s",path,patchFileName);
On 2010/06/04 18:01:18, Sam Leffler wrote:
> snprintf

Done.

http://codereview.chromium.org/2649001/diff/1/6
File drivers/bluetooth/hci_ath.c (right):

http://codereview.chromium.org/2649001/diff/1/6#newcode346
drivers/bluetooth/hci_ath.c:346: BT_ERR("HCIATH protocol registration failed");
On 2010/06/04 18:01:18, Sam Leffler wrote:
> include err in msg unless it gets displayed somewhere else

the return value of this function is actually ignored.... 

Added the error code to the printout.

[Sam Leffler, 2010-06-07 15:34:28]

LGTM