Convert devtools interfaces over to using WebString....

Convert devtools interfaces over to using WebString.

Also converts some internal std::string usage to WebCore::String.
Note: copying WebString to WebCore::String is very cheap (just
increments a reference count). 

The ugly WebStringToString and StringToWebString calls inside the
devtools implementation are temporary.  Once this code moves into
the WebKit API implementation, those methods will go away.

I thought about changing the devtools IPCs to use string16 instead
of std::string because that would avoid the UTF8 conversions.  I'm
not sure if that is worth it though given that UTF16 would increase
the amount of data being sent over IPC.  I figure this is something
that could be studied later.

R=pfeldman
BUG=24597
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29286

[yurys, 2009-10-16 11:23:02]

On 2009/10/16 07:52:47, darin wrote:
> 

LGTM

[yurys, 2009-10-16 11:23:33]

LGTM, thanks for fixing that!

http://codereview.chromium.org/264077/diff/1/15
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/264077/diff/1/15#newcode44
Line 44: static v8::Local<v8::String> ToV8String(const String& s) {
consider placing it into an anonymous namespace

[darin (slow to review), 2009-10-16 15:36:42]

Thanks for the review!

On Fri, Oct 16, 2009 at 4:23 AM, <yurys@chromium.org> wrote:

> LGTM, thanks for fixing that!
>
>
> http://codereview.chromium.org/264077/diff/1/15
> File webkit/glue/webdevtoolsclient_impl.cc (right):
>
> http://codereview.chromium.org/264077/diff/1/15#newcode44
> Line 44: static v8::Local<v8::String> ToV8String(const String& s) {
> consider placing it into an anonymous namespace


I marked this function static, which has the same effect.  I'm happy
to use an anonymous namespace instead if you prefer that stylistically.

-Darin




>
>
> http://codereview.chromium.org/264077
>

[yurys, 2009-10-16 15:41:31]

http://codereview.chromium.org/264077/diff/1/15
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/264077/diff/1/15#newcode44
Line 44: static v8::Local<v8::String> ToV8String(const String& s) {
On 2009/10/16 11:23:33, Yury Semikhatsky wrote:
> consider placing it into an anonymous namespace

Oh, it's static, never mind then.