Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 264042: Less busywork for nested Mac run loops (Closed)

Created:
11 years, 2 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, brettw+cc_chromium.org
Visibility:
Public.

Description

When a nested run loop is driven directly by Run/DoRun as opposed to being a nested native loop run by code outside of our control, and the nested run loop stops, don't schedule nesting-deferred work until returning fron Run/DoRun. BUG=24337, 24383 TEST=With r28745 backed out or an equivalent change recommitted: 1. Test case from bug 24337: the window should close 2. Test case from bug 24383: no Chromium processes should use 100% CPU Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M base/message_pump_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/message_pump_mac.mm View 8 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
I always have a hard time picking run loop reviewers.
11 years, 2 months ago (2009-10-13 01:18:34 UTC) #1
Mark Mentovai
With r28745 backed out, this does fix bug 24337.
11 years, 2 months ago (2009-10-13 02:25:15 UTC) #2
John Grabowski
Unit tests? We've found a few knarly bugs down here. Might be nice to increase ...
11 years, 2 months ago (2009-10-13 02:35:45 UTC) #3
darin (slow to review)
Do you still need to run a TYPE_UI message loop in the renderer?-Darin On Mon, ...
11 years, 2 months ago (2009-10-13 04:41:16 UTC) #4
TVL
11 years, 2 months ago (2009-10-13 12:08:03 UTC) #5
lg

Powered by Google App Engine
This is Rietveld 408576698