Cleanup of about box

Cleanup of about box

Removed redundent version from update string.
Added a line break to the ChromeOS version on test builds to improve appearence
(select and drag to see complete version).
Added margins to multiline edit fields without borders to make them match
single line edit fields in positioning.
Fixed an issue with setting the initial focus for GTK based windows. This
fixes the problem of the cursor showing up in the version field.

BUG=chromium-os:3571
1589 2967
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49322

[DaveMoore, 2010-06-04 21:49:57]

Isn't this going to still have the update say "Chrome is up to date" and don't
we want "Chrome OS" to appear everywhere (with the same versioning as Chrome?")

http://codereview.chromium.org/2620003/diff/1/3
File chrome/browser/views/about_chrome_view.cc (right):

http://codereview.chromium.org/2620003/diff/1/3#newcode671
chrome/browser/views/about_chrome_view.cc:671: if (pos != std::string::npos)
version.replace(pos, 1, "\n");
no one line if() statements

http://codereview.chromium.org/2620003/diff/1/5
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/2620003/diff/1/5#newcode193
views/controls/textfield/native_textfield_gtk.cc:193: }
Brace indented wrong

[Sean Parent, 2010-06-04 22:05:13]

Regarding Chrome vs. Chrome OS - Cole has gone back and forth on this, and my
next task is to replace the about box with DOM UI so this pass is just so things
aren't too ugly/wrong.

http://codereview.chromium.org/2620003/diff/1/3
File chrome/browser/views/about_chrome_view.cc (right):

http://codereview.chromium.org/2620003/diff/1/3#newcode671
chrome/browser/views/about_chrome_view.cc:671: if (pos != std::string::npos)
version.replace(pos, 1, "\n");
On 2010/06/04 21:49:57, davemoore wrote:
> no one line if() statements

From the style guide:
"Short conditional statements may be written on one line if this enhances
readability. You may use this only when the line is brief and the statement does
not use the else clause."

There is an addition in the Chromium style guide:

"For conditional return statements, the return should be indented on its own
line (for easier tracing)."

So I think this is good.

http://codereview.chromium.org/2620003/diff/1/5
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/2620003/diff/1/5#newcode193
views/controls/textfield/native_textfield_gtk.cc:193: }
On 2010/06/04 21:49:57, davemoore wrote:
> Brace indented wrong

Done.

[DaveMoore, 2010-06-04 22:48:22]

http://codereview.chromium.org/2620003/diff/1/3
File chrome/browser/views/about_chrome_view.cc (right):

http://codereview.chromium.org/2620003/diff/1/3#newcode671
chrome/browser/views/about_chrome_view.cc:671: if (pos != std::string::npos)
version.replace(pos, 1, "\n");
I don't see many occurrences of it. I think in general the team avoids it. I
don't think it should go into a file that you're just adding a little bit to.

On 2010/06/04 22:05:13, Sean Parent wrote:
> On 2010/06/04 21:49:57, davemoore wrote:
> > no one line if() statements
> 
> From the style guide:
> "Short conditional statements may be written on one line if this enhances
> readability. You may use this only when the line is brief and the statement
does
> not use the else clause."
> 
> There is an addition in the Chromium style guide:
> 
> "For conditional return statements, the return should be indented on its own
> line (for easier tracing)."
> 
> So I think this is good.
> 
> 
> 
> 
>

[DaveMoore, 2010-06-09 16:51:50]

LGTM