Issue 261058: Unit test for https://bugs.webkit.org/show_bug.cgi?id=30262...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261058: Unit test for https://bugs.webkit.org/show_bug.cgi?id=30262... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
eseidel

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Unit test for https://bugs.webkit.org/show_bug.cgi?id=30262 R=eseidel BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28792

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	webkit/tools/webcore_unit_tests/GKURL_unittest.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eseidel

11 years, 2 months ago (2009-10-10 05:02:02 UTC) #2

LGTM.

On Fri, Oct 9, 2009 at 11:53 PM,  <darin@chromium.org> wrote:
> Reviewers: Eric Seidel (Google),
>
> Description:
> Unit test for https://bugs.webkit.org/show_bug.cgi?id=3D30262
>
> R=3Deseidel
> BUG=3Dnone
> TEST=3Dnone
>
>
> Please review this at http://codereview.chromium.org/261058
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 webkit/tools/webcore_unit_tests/GKURL_unittest.cpp
>
>
> Index: webkit/tools/webcore_unit_tests/GKURL_unittest.cpp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- webkit/tools/webcore_unit_tests/GKURL_unittest.cpp =A0(revision 28588=
)
> +++ webkit/tools/webcore_unit_tests/GKURL_unittest.cpp =A0(working copy)
> @@ -599,3 +599,13 @@
> =A0 EXPECT_NE(dest.string().characters(), src.string().characters());
> =A0 EXPECT_NE(dest.utf8String().data(), src.utf8String().data());
> =A0}
> +
> +TEST(GKURL, ProtocolIs) {
> + =A0WebCore::KURL url1(WebCore::ParsedURLString,"foo://bar");
> + =A0EXPECT_TRUE(url1.protocolIs("foo"));
> + =A0EXPECT_FALSE(url1.protocolIs("foo-bar"));
> +
> + =A0WebCore::KURL url2(WebCore::ParsedURLString,"foo-bar:");
> + =A0EXPECT_TRUE(url2.protocolIs("foo-bar"));
> + =A0EXPECT_FALSE(url2.protocolIs("foo"));
> +}
>
>
>

Expand Messages | Collapse Messages