Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 261012: Committing change 255087 for Roger:... (Closed)

Created:
11 years, 2 months ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Committing change 255087 for Roger: TBR=amit http://codereview.chromium.org/255087 Adding a unique runtime Id to Profile objects, that can be used as the key of the ProfileSiteInstanceMap type. This is used to make sure that Profile objects can correctly share site information when one profile is derived from another. BUG=0 TEST=See unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -18 lines) Patch
M chrome/browser/automation/automation_profile_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_instance.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browsing_instance.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/profile.h View 5 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/profile.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.h View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
11 years, 2 months ago (2009-10-07 20:19:04 UTC) #1
amit
11 years, 2 months ago (2009-10-07 20:54:44 UTC) #2
LGTM, Thanks Tommi.

On Wed, Oct 7, 2009 at 1:19 PM, <tommi@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Committing change 255087 for Roger:
> TBR=amit
>
>
> http://codereview.chromium.org/255087
>
> Adding a unique runtime Id to Profile objects, that can be used as the key
> of the ProfileSiteInstanceMap type. This is used to make sure that Profile
> objects can correctly share site information when one profile is derived
> from another.
>
> BUG=0
> TEST=See unit tests
>
>
>
> Please review this at http://codereview.chromium.org/261012
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/automation/automation_profile_impl.h
>  M     chrome/browser/automation/automation_resource_message_filter.cc
>  M     chrome/browser/browsing_instance.h
>  M     chrome/browser/browsing_instance.cc
>  M     chrome/browser/profile.h
>  M     chrome/browser/profile.cc
>  M     chrome/test/testing_profile.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698