Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2604273002: Migrate data from old localstorage format to new format. (Closed)

Created:
3 years, 11 months ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
michaeln, jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate data from old localstorage format to new format. If when loading data from LevelDB no data is found for a particular origin this causes data to be (attempted) to be loaded from SQLite instead. As soon as any data has been successfully written to (disk backed) LevelDB the SQLite database for that origin is deleted. Rather than adding even more callbacks to LevelDBWrapperImpl this changes all existing callbacks and a few new ones to be part of one Delegate interface. BUG=586194 Review-Url: https://codereview.chromium.org/2604273002 Cr-Commit-Position: refs/heads/master@{#444152} Committed: https://chromium.googlesource.com/chromium/src/+/222214f0eedbdc9dc393a7cb40e370d4751d4fd1

Patch Set 1 #

Patch Set 2 : different approach to data migration #

Patch Set 3 : self review #

Patch Set 4 : try to fix windows build #

Total comments: 1

Patch Set 5 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -131 lines) Patch
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 chunks +15 lines, -12 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.h View 1 2 4 chunks +11 lines, -5 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 2 6 chunks +154 lines, -68 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 2 3 4 14 chunks +104 lines, -15 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 1 2 3 5 chunks +19 lines, -11 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 8 chunks +44 lines, -13 lines 0 comments Download
M content/browser/leveldb_wrapper_impl_unittest.cc View 1 3 chunks +10 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 30 (25 generated)
Marijn Kruisselbrink
3 years, 11 months ago (2017-01-13 21:02:17 UTC) #12
jam
ltm, great https://codereview.chromium.org/2604273002/diff/60001/content/browser/dom_storage/local_storage_context_mojo_unittest.cc File content/browser/dom_storage/local_storage_context_mojo_unittest.cc (right): https://codereview.chromium.org/2604273002/diff/60001/content/browser/dom_storage/local_storage_context_mojo_unittest.cc#newcode613 content/browser/dom_storage/local_storage_context_mojo_unittest.cc:613: // Origin should no longer exist in ...
3 years, 11 months ago (2017-01-13 23:51:16 UTC) #19
jam
On 2017/01/13 23:51:16, jam wrote: > ltm, great oops I misspelled that, lgtm
3 years, 11 months ago (2017-01-17 19:26:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604273002/80001
3 years, 11 months ago (2017-01-17 21:24:46 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:31:31 UTC) #30
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/222214f0eedbdc9dc393a7cb40e3...

Powered by Google App Engine
This is Rietveld 408576698