Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: content/browser/leveldb_wrapper_impl_unittest.cc

Issue 2604273002: Migrate data from old localstorage format to new format. (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/leveldb_wrapper_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/leveldb_wrapper_impl_unittest.cc
diff --git a/content/browser/leveldb_wrapper_impl_unittest.cc b/content/browser/leveldb_wrapper_impl_unittest.cc
index 8e81ff4e2567044d243d99bc6453d0d551504b51..a753a94b74b13d2fcb16f5ae2836050425f6869e 100644
--- a/content/browser/leveldb_wrapper_impl_unittest.cc
+++ b/content/browser/leveldb_wrapper_impl_unittest.cc
@@ -52,11 +52,14 @@ class GetAllCallback : public mojom::LevelDBWrapperGetAllCallback {
base::Closure m_callback;
};
-void NoOp() {}
-std::vector<leveldb::mojom::BatchedOperationPtr> PrepareToCommitNoOp(
- const LevelDBWrapperImpl&) {
- return std::vector<leveldb::mojom::BatchedOperationPtr>();
-}
+class MockDelegate : public LevelDBWrapperImpl::Delegate {
+ public:
+ void OnNoBindings() override {}
+ std::vector<leveldb::mojom::BatchedOperationPtr> PrepareToCommit() override {
+ return std::vector<leveldb::mojom::BatchedOperationPtr>();
+ }
+ void DidCommit(leveldb::mojom::DatabaseError error) override {}
+};
void GetCallback(const base::Closure& callback,
bool* success_out,
@@ -98,8 +101,7 @@ class LevelDBWrapperImplTest : public testing::Test,
base::TimeDelta::FromSeconds(5),
10 * 1024 * 1024 /* max_bytes_per_hour */,
60 /* max_commits_per_hour */,
- base::Bind(&NoOp),
- base::Bind(&PrepareToCommitNoOp)),
+ &delegate_),
observer_binding_(this) {
set_mock_data(std::string(kTestPrefix) + "def", "defdata");
set_mock_data(std::string(kTestPrefix) + "123", "123data");
@@ -209,6 +211,7 @@ class LevelDBWrapperImplTest : public testing::Test,
TestBrowserThreadBundle thread_bundle_;
std::map<std::vector<uint8_t>, std::vector<uint8_t>> mock_data_;
MockLevelDBDatabase db_;
+ MockDelegate delegate_;
LevelDBWrapperImpl level_db_wrapper_;
mojom::LevelDBWrapperPtr level_db_wrapper_ptr_;
mojo::AssociatedBinding<mojom::LevelDBObserver> observer_binding_;
« no previous file with comments | « content/browser/leveldb_wrapper_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698