Issue 259050: Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259050: Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.... (Closed)

Created:
11 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28037

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -2 lines)			Patch
M	chrome/browser/blocked_popup_container.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/blocked_popup_container.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/blocked_popup_container_view_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dank

In general there's no reason to move initialization to the .cc file, may as well ...

11 years, 2 months ago (2009-10-05 20:49:33 UTC) #2

Peter Kasting

On 2009/10/05 20:49:33, dank wrote: > In general there's no reason to move initialization to ...

11 years, 2 months ago (2009-10-05 20:51:16 UTC) #3

dank

On 2009/10/05 20:51:16, Peter Kasting wrote: > In general we don't want to allocate real ...

11 years, 2 months ago (2009-10-05 20:54:56 UTC) #4

Peter Kasting

11 years, 2 months ago (2009-10-05 20:56:53 UTC) #5

On 2009/10/05 20:54:56, dank wrote:
> Putting the initialization in the .h file does not allocate storage --
> that's why you got the link error.

Oh, I mistook what you were suggesting doing.

It seems weird to me to initialize something at its declaration and not at its
definition.  Doing it the other way just feels more natural.

Expand Messages | Collapse Messages