Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: chrome/browser/blocked_popup_container.h

Issue 259050: Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/blocked_popup_container.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this
2 // source code is governed by a BSD-style license that can be found in the 2 // source code is governed by a BSD-style license that can be found in the
3 // LICENSE file. 3 // LICENSE file.
4 4
5 // Defines the public interface for the blocked popup notifications. This 5 // Defines the public interface for the blocked popup notifications. This
6 // interface should only be used by TabContents. Users and subclasses of 6 // interface should only be used by TabContents. Users and subclasses of
7 // TabContents should use the appropriate methods on TabContents to access 7 // TabContents should use the appropriate methods on TabContents to access
8 // information about blocked popups. 8 // information about blocked popups.
9 9
10 // TODO(idanan): Rename class to BlockedContentContainer. 10 // TODO(idanan): Rename class to BlockedContentContainer.
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 192
193 // Ignored; BlockedPopupContainer doesn't display a bookmarking star. 193 // Ignored; BlockedPopupContainer doesn't display a bookmarking star.
194 virtual void URLStarredChanged(TabContents* source, bool starred) { } 194 virtual void URLStarredChanged(TabContents* source, bool starred) { }
195 195
196 // Ignored; BlockedPopupContainer doesn't display a URL bar. 196 // Ignored; BlockedPopupContainer doesn't display a URL bar.
197 virtual void UpdateTargetURL(TabContents* source, const GURL& url) { } 197 virtual void UpdateTargetURL(TabContents* source, const GURL& url) { }
198 198
199 // A number larger than the internal popup count on the Renderer; meant for 199 // A number larger than the internal popup count on the Renderer; meant for
200 // preventing a compromised renderer from exhausting GDI memory by spawning 200 // preventing a compromised renderer from exhausting GDI memory by spawning
201 // infinite windows. 201 // infinite windows.
202 static const size_t kImpossibleNumberOfPopups = 30; 202 static const size_t kImpossibleNumberOfPopups;
203 203
204 protected: 204 protected:
205 struct BlockedPopup { 205 struct BlockedPopup {
206 BlockedPopup(TabContents* tab_contents, 206 BlockedPopup(TabContents* tab_contents,
207 const gfx::Rect& bounds, 207 const gfx::Rect& bounds,
208 const std::string& host) 208 const std::string& host)
209 : tab_contents(tab_contents), bounds(bounds), host(host) { 209 : tab_contents(tab_contents), bounds(bounds), host(host) {
210 } 210 }
211 211
212 TabContents* tab_contents; 212 TabContents* tab_contents;
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 // Our platform specific view. 308 // Our platform specific view.
309 BlockedPopupContainerView* view_; 309 BlockedPopupContainerView* view_;
310 310
311 // The profile for the browser associated with the container. 311 // The profile for the browser associated with the container.
312 Profile* profile_; 312 Profile* profile_;
313 313
314 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedPopupContainer); 314 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedPopupContainer);
315 }; 315 };
316 316
317 #endif // CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_ 317 #endif // CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/blocked_popup_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698