Make Mac WebCursor glue use the nsimage_cache

Make Mac WebCursor glue use the nsimage_cache

BUG=16438, 14610
(in in support of bundling changes to fix autoupdate)
TEST=Hover over a link, get the finger

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28027

[TVL, 2009-10-05 19:23:11]

LG

please add bug 16438 to the cl description.

maybe make the comment below a todo or new bug?

http://codereview.chromium.org/259049/diff/2001/4
File webkit/glue/webcursor_mac.mm (left):

http://codereview.chromium.org/259049/diff/2001/4#oldcode21
Line 21: // TODO(avi): Is loading resources what we want to do here?
should we actually fetch the images from the resource bundle (since they are
there)

[darin (slow to review), 2009-10-05 20:22:30]

hmm... side note, but nsimage_cache sounds like something that shouldn't be
in base.  perhaps it should live in the new app module instead?-darin

On Mon, Oct 5, 2009 at 12:18 PM, <mark@chromium.org> wrote:

> Reviewers: TVL,
>
> Description:
> Make Mac WebCursor glue use the nsimage_cache
>
> BUG=14610 (this change in in support of bundling changes to fix autoupdate)
> TEST=Hover over a link, get the finger
>
> Please review this at http://codereview.chromium.org/259049
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     webkit/glue/webcursor_mac.mm
>
>
> Index: webkit/glue/webcursor_mac.mm
> ===================================================================
> --- webkit/glue/webcursor_mac.mm        (revision 28016)
> +++ webkit/glue/webcursor_mac.mm        (working copy)
> @@ -7,6 +7,7 @@
>  #import <AppKit/AppKit.h>
>
>  #include "base/logging.h"
> +#include "base/nsimage_cache_mac.h"
>  #include "base/scoped_cftyperef.h"
>  #include "webkit/api/public/WebCursorInfo.h"
>  #include "webkit/api/public/WebImage.h"
> @@ -22,7 +23,7 @@
>  NSCursor* LoadCursor(const char* name, int x, int y) {
>   NSString* file_name = [NSString stringWithUTF8String:name];
>   DCHECK(file_name);
> -  NSImage* cursor_image = [NSImage imageNamed:file_name];
> +  NSImage* cursor_image = nsimage_cache::ImageNamed(file_name);
>   DCHECK(cursor_image);
>   return [[[NSCursor alloc] initWithImage:cursor_image
>                                   hotSpot:NSMakePoint(x, y)] autorelease];
>
>
>