Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 259047: Move classes depending on Skia out of base/gfx and into app/gfx. Rename... (Closed)

Created:
11 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, fbarchard, Alpha Left Google, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, jam, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing), scherkus (not reviewing)
Visibility:
Public.

Description

Move classes depending on Skia out of base/gfx and into app/gfx. Rename native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28300

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -1581 lines) Patch
M app/app.gyp View 5 chunks +16 lines, -0 lines 0 comments Download
A + app/gfx/blit.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + app/gfx/blit.cc View 1 chunk +1 line, -1 line 0 comments Download
A + app/gfx/gdi_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + app/gfx/gdi_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + app/gfx/gtk_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + app/gfx/native_theme_win.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + app/gfx/native_theme_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + app/gfx/native_theme_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M app/resource_bundle_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/win_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + app\gfx\gtk_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M base/base.gyp View 5 chunks +0 lines, -17 lines 0 comments Download
D base/gfx/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D base/gfx/blit.h View 1 chunk +0 lines, -47 lines 0 comments Download
D base/gfx/blit.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D base/gfx/gdi_util.h View 1 chunk +0 lines, -36 lines 0 comments Download
D base/gfx/gdi_util.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D base/gfx/gtk_util.h View 1 chunk +0 lines, -67 lines 0 comments Download
D base/gfx/gtk_util.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D base/gfx/native_theme.h View 1 chunk +0 lines, -296 lines 0 comments Download
D base/gfx/native_theme.cc View 1 chunk +0 lines, -710 lines 0 comments Download
D base/gfx/native_theme_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_theme_provider_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/about_chrome_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/blocked_popup_container_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_editor_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_menu_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/custom_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/download_shelf_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_install_prompt_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_shelf_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/first_run_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/gtk_chrome_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/info_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/keyword_editor_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/list_store_favicon_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/nine_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/cookies_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/exceptions_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/passwords_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/url_picker_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/status_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/task_manager_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/backing_store_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/options/languages_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/options_group_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webmediaplayer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M printing/image.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 6 chunks +15 lines, -6 lines 0 comments Download
M skia/ext/vector_platform_device_win.cc View 3 chunks +26 lines, -4 lines 0 comments Download
M views/controls/combobox/native_combobox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_config_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_item_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_scroll_view_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_separator_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/native_control.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M views/controls/slider/native_slider_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M views/drag_utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/widget_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M views/window/dialog_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/gtk_plugin_container_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webcursor_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webthemeengine_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 2 months ago (2009-10-07 18:35:54 UTC) #1
sky
11 years, 2 months ago (2009-10-07 19:16:20 UTC) #2
As long as this compiles, LGTM.

Powered by Google App Engine
This is Rietveld 408576698