Issue 259008: Add (yet another) option to allow stripping the chrome binary after dumping s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259008: Add (yet another) option to allow stripping the chrome binary after dumping s... (Closed)

Created:
11 years, 2 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Michael Moss

CC:
chromium-reviews_googlegroups.com, huanr

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add (yet another) option to allow stripping the chrome binary after dumping symbols. Chromebot does not like 200MB zip files and 800MB chrome binaries. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27795

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -7 lines)			Patch
M	build/common.gypi	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	build/linux/dump_app_syms	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Moss

LGTM with one nit http://codereview.chromium.org/259008/diff/1/3 File build/linux/dump_app_syms (right): http://codereview.chromium.org/259008/diff/1/3#newcode14 Line 14: echo "<symbols_output> <strip_binary>" >&2 ...

11 years, 2 months ago (2009-10-01 23:12:12 UTC) #2

fixed.

Expand Messages | Collapse Messages