Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3664)

Unified Diff: build/linux/dump_app_syms

Issue 259008: Add (yet another) option to allow stripping the chrome binary after dumping s... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/linux/dump_app_syms
===================================================================
--- build/linux/dump_app_syms (revision 27758)
+++ build/linux/dump_app_syms (working copy)
@@ -10,19 +10,21 @@
set -e
usage() {
- echo "$0 <dump_syms_exe> <binary_with_symbols> <symbols_output>" >&2
+ echo -n "$0 <dump_syms_exe> <strip_binary> " >&2
+ echo "<binary_with_symbols> <symbols_output>" >&2
}
-if [ $# -ne 3 ]; then
+if [ $# -ne 4 ]; then
usage
exit 1
fi
SCRIPTDIR="$(readlink -f "$(dirname "$0")")"
DUMPSYMS="$1"
-INFILE="$2"
-OUTFILE="$3"
+KEEP_STRIPPED_BINARY="$2"
+INFILE="$3"
+OUTFILE="$4"
STRIPPED=$(mktemp -q -t stripped-XXXXX)
if [ $? -ne 0 ]; then
@@ -38,7 +40,11 @@
# Strip the binary and calculate the signature of that, since that's what ships.
strip "$INFILE" -o "$STRIPPED"
NEWSIG=$("$SCRIPTDIR/dump_signature.py" "$STRIPPED")
-rm "$STRIPPED"
+if [ "$KEEP_STRIPPED_BINARY" != "0" ]; then
+ mv "$STRIPPED" "$INFILE"
+else
+ rm "$STRIPPED"
+fi
# Replace the old signature with the stripped signature in the symbols file.
sed -i "1s/ [0-9A-F]* / $NEWSIG /" "$OUTFILE"
Property changes on: build/linux/dump_app_syms
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698