Issue 259001: [Mac] Don't crash when selecting closed window from Dock menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259001: [Mac] Don't crash when selecting closed window from Dock menu. (Closed)

Created:
11 years, 2 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Don't crash when selecting closed window from Dock menu. The Dock menu contains an automagic section where you can select amongst open windows. This is wired up to send to the window as a target, but if JavaScript closes the window in the meanwhile, it messages a freed object. This short-circuits the specific selector if the window is no longer valid. http://crbug.com/14003 TEST=Bug contains instructions and an example html file to help.

Patch Set 1 #

Patch Set 2 : Don't use -containsObject: in case it messages |aTarget|. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	chrome/browser/chrome_application_mac.mm	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Not a bug marked for beta, but Kris keeps sending it out in the list ...

11 years, 2 months ago (2009-10-01 18:16:36 UTC) #1

Mark Mentovai

LGTM. You had said that this might not be a bug in 10.6. Could you ...

11 years, 2 months ago (2009-10-01 18:30:36 UTC) #2

Scott Hess - ex-Googler

11 years, 2 months ago (2009-10-01 19:41:43 UTC) #3

krisr indicates in the bug that it repros on SL.  I believe I only
tried to repro using Safari on SL (this was @WWDC), maybe they fixed
it in Safari instead of in the OS.

-scott

On Thu, Oct 1, 2009 at 11:30 AM,  <mark@chromium.org> wrote:
> LGTM. =A0You had said that this might not be a bug in 10.6. =A0Could you =
verify
> that? =A0If Apple has fixed this in 10.6, you should add a note to that e=
ffect
> in
> your comment (but no code change is necessary).
>
> http://codereview.chromium.org/259001
>

Expand Messages | Collapse Messages