Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2586001: Add test_b(Operand, immediate) to ia32 assembler, and use it where possible. ... (Closed)

Created:
10 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add test_b(Operand, immediate) to ia32 assembler, and use it where possible. Improve comparison to a constant one-character string. Use CmpInstanceType in more places on ia32. Add IsObjectJSObjectType and IsInstanceJSObjectType to ia32 macro assembler, using a single branch for a range test. Committed: http://code.google.com/p/v8/source/detail?r=4795

Patch Set 1 #

Total comments: 7

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -130 lines) Patch
M src/ia32/assembler-ia32.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 3 chunks +9 lines, -11 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 18 chunks +61 lines, -99 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 8 chunks +14 lines, -16 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
10 years, 6 months ago (2010-06-03 16:46:22 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/2586001/diff/1/4 File src/ia32/builtins-ia32.cc (right): http://codereview.chromium.org/2586001/diff/1/4#newcode616 src/ia32/builtins-ia32.cc:616: __ CmpObjectType(ebx, FIRST_JS_OBJECT_TYPE, ecx); This seems to be ...
10 years, 6 months ago (2010-06-04 07:46:23 UTC) #2
William Hesse
10 years, 6 months ago (2010-06-04 10:42:08 UTC) #3
Comments addressed.

http://codereview.chromium.org/2586001/diff/1/4
File src/ia32/builtins-ia32.cc (right):

http://codereview.chromium.org/2586001/diff/1/4#newcode616
src/ia32/builtins-ia32.cc:616: __ CmpObjectType(ebx, FIRST_JS_OBJECT_TYPE, ecx);
On 2010/06/04 07:46:23, Lasse Reichstein wrote:
> This seems to be comparing the instance type with a range, and not using the
> value after that.
> We should be able to reduce that to a single unsigned comparison and jump.
Could
> we add a macro that did range-comparison, e.g.,
>  CmpObjectTypeRange(ebx, FIRST_JS_OBJECT_TYPE, LAST_JS_OBJECT_TYPE, ecx)
> where ecx is used as scratch (no guarantees on the value afterwards).
> 

Done.

http://codereview.chromium.org/2586001/diff/1/5
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/2586001/diff/1/5#newcode2735
src/ia32/codegen-ia32.cc:2735: // If the length is 0 then the subtraction gave
-1, setting
On 2010/06/04 07:46:23, Lasse Reichstein wrote:
> Comment is out of sync (there is no longer a subtraction).

Done.

Powered by Google App Engine
This is Rietveld 408576698