src/ia32/stub-cache-ia32.cc - Issue 2586001: Add test_b(Operand, immediate) to ia32 assembler, and use it where possible. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 2586001: Add test_b(Operand, immediate) to ia32 assembler, and use it where possible. ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

===================================================================

--- src/ia32/stub-cache-ia32.cc (revision 4792)

+++ src/ia32/stub-cache-ia32.cc (working copy)

@@ -1520,9 +1520,7 @@

__ jmp(&miss);

} else {

// Check that the object is a string or a symbol.

- __ mov(eax, FieldOperand(edx, HeapObject::kMapOffset));

- __ movzx_b(eax, FieldOperand(eax, Map::kInstanceTypeOffset));

- __ cmp(eax, FIRST_NONSTRING_TYPE);

+ __ CmpObjectType(edx, FIRST_NONSTRING_TYPE, eax);

__ j(above_equal, &miss, not_taken);

// Check that the maps starting from the prototype haven't changed.

GenerateLoadGlobalFunctionPrototype(masm(),

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »