Fixes a bug that .crx can not be installed by "Could not create...

base/file_util_win.cc

Index: base/file_util_win.cc
===================================================================
--- base/file_util_win.cc	(revision 28515)
+++ base/file_util_win.cc	(working copy)
@@ -428,9 +428,7 @@
   // TODO(evanm): the old behavior of this function was to always strip the
   // trailing slash.  We duplicate this here, but it shouldn't be necessary
   // when everyone is using the appropriate FilePath APIs.
-  std::wstring path_str(temp_path);
-  TrimTrailingSeparator(&path_str);
-  *path = FilePath(path_str);
+  *path = FilePath(temp_path).StripTrailingSeparators();

[Erik does not do reviews, 2009/10/09 14:16:33]

If this changes anything for your test case, then something else is broken. 
StripTrailingSeparator on "C:\" should still be "C:\".  IsAbsolutePath on "C:\"
should be true and on "C:" should be false.  Am I misunderstanding something
here?

[Mark Mentovai, 2009/10/09 14:31:16]

I agree.  It looks like file_util::TrimTrailingSeparator is dangerously broken.

leiz added it, maybe we should hear what he has to say.

[tkent, 2009/10/09 15:09:34]

You're right.  As Mark wrote, TrimTrailingSeprator() which was used here in the
previous revision made "C:" from "C:\".  It made the bug.

We had better remove TrimTrailingSeparator().

   return true;
 }