Fixes a bug that .crx can not be installed by "Could not create...

base/file_util_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
 #include <time.h>
@@ skipping 410 matching lines @@
 }
 
 bool GetTempDir(FilePath* path) {
   wchar_t temp_path[MAX_PATH + 1];
   DWORD path_len = ::GetTempPath(MAX_PATH, temp_path);
   if (path_len >= MAX_PATH || path_len <= 0)
     return false;
   // TODO(evanm): the old behavior of this function was to always strip the
   // trailing slash.  We duplicate this here, but it shouldn't be necessary
   // when everyone is using the appropriate FilePath APIs.
-  std::wstring path_str(temp_path);
-  TrimTrailingSeparator(&path_str);
-  *path = FilePath(path_str);
+  *path = FilePath(temp_path).StripTrailingSeparators();

[Erik does not do reviews, 2009/10/09 14:16:33]

If this changes anything for your test case, then something else is broken. 
StripTrailingSeparator on "C:\" should still be "C:\".  IsAbsolutePath on "C:\"
should be true and on "C:" should be false.  Am I misunderstanding something
here?

[Mark Mentovai, 2009/10/09 14:31:16]

I agree.  It looks like file_util::TrimTrailingSeparator is dangerously broken.

leiz added it, maybe we should hear what he has to say.

[tkent, 2009/10/09 15:09:34]

You're right.  As Mark wrote, TrimTrailingSeprator() which was used here in the
previous revision made "C:" from "C:\".  It made the bug.

We had better remove TrimTrailingSeparator().

   return true;
 }
 
 bool GetShmemTempDir(FilePath* path) {
   return GetTempDir(path);
 }
 
 bool CreateTemporaryFile(FilePath* path) {
   FilePath temp_file;
 
@@ skipping 358 matching lines @@
     ::CloseHandle(file_mapping_);
   if (file_ != INVALID_HANDLE_VALUE)
     ::CloseHandle(file_);
 
   data_ = NULL;
   file_mapping_ = file_ = INVALID_HANDLE_VALUE;
   length_ = INVALID_FILE_SIZE;
 }
 
 }  // namespace file_util