Issue 257047: Fix bug 23303: ui_tests crash Windows 7's shell when running WorkerHttpLayout...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257047: Fix bug 23303: ui_tests crash Windows 7's shell when running WorkerHttpLayout... (Closed)

Created:
11 years, 2 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix bug 23303: ui_tests crash Windows 7's shell when running WorkerHttpLayoutTests. The crash is caused by lighttpd server starting on the foreground mode and it messed up with the command window host. To work around this, we start the http server on the background mode if running UI test under Windows 7. BUG=23303 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28030

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	chrome/test/ui/ui_test.cc	View		2 chunks	+12 lines, -0 lines	1 comment	Download
	M	webkit/tools/layout_tests/layout_package/http_server.py	View		5 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/257047/diff/1/3 File chrome/test/ui/ui_test.cc (right): http://codereview.chromium.org/257047/diff/1/3#newcode20 Line 20: #if defined(OS_WIN) nit: I believe we always ...

11 years, 2 months ago (2009-10-05 19:31:28 UTC) #2

jianli

11 years, 2 months ago (2009-10-05 20:38:00 UTC) #3

Fixed and landed. Thanks.

On Mon, Oct 5, 2009 at 12:31 PM, <jam@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/257047/diff/1/3
> File chrome/test/ui/ui_test.cc (right):
>
> http://codereview.chromium.org/257047/diff/1/3#newcode20
> Line 20: #if defined(OS_WIN)
> nit: I believe we always put the OS specific defines after the main
> #include block.
>
>
> http://codereview.chromium.org/257047
>

Expand Messages | Collapse Messages