Issue 256060: New frame image from Nicholas.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256060: New frame image from Nicholas. (Closed)

Created:
11 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

New frame image from Nicholas. BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28045

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	chrome/app/theme/theme_frame_default2.png	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 2 months ago (2009-10-05 21:26:38 UTC) #2

LGTM

On Mon, Oct 5, 2009 at 2:09 PM,  <sky@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> New frame image from Nicholas.
>
> BUG=3Dnone
> TEST=3Dnone
> TBR=3Dbrettw
>
> Please review this at http://codereview.chromium.org/256060
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/app/theme/theme_frame_default2.png
>
>
> Index: chrome/app/theme/theme_frame_default2.png
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> Cannot display: file marked as a binary type.
> svn:mime-type =3D image/png
>
>
>

Expand Messages | Collapse Messages