Issue 256041: Fast fix to make tree green.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256041: Fast fix to make tree green. (Closed)

Created:
11 years, 2 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Lasse Reichstein, Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fast fix to make tree green. Committed: http://code.google.com/p/v8/source/detail?r=3015

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	src/checks.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		7 chunks	+13 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 2 months ago (2009-10-02 20:01:23 UTC) #2

Drive by comments.

http://codereview.chromium.org/256041/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/256041/diff/1/2#newcode706
Line 706: # define CAST_TO_INT64(x) (int(x))
It seems counter-intuitive to have a macro called CAST_TO_INT64 that casts to a
32-bit integer type.

I'd prefer CAST_TO_V8_INTEGER_VALUE (since it seems it casts to the return type
of Integer::Value).

I'd prefer C++ style casts, i.e., static_cast<int>(x).

Expand Messages | Collapse Messages