Fast fix to make tree green.

test/cctest/test-api.cc

 // Copyright 2007-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 684 matching lines @@
   LocalContext env;
   Local<Function> fun = fun_templ->GetFunction();
   env->Global()->Set(v8_str("Fun"), fun);
   Local<Script> getter = v8_compile("var obj = new Fun(); obj.foo;");
   CHECK_EQ(900, getter->Run()->Int32Value());
   Local<Script> setter = v8_compile("obj.foo = 901;");
   CHECK_EQ(901, setter->Run()->Int32Value());
 }
 
 
+#if V8_HOST_ARCH_64_BIT
+# define CAST_TO_INT64(x) (int(x))

[Lasse Reichstein, 2009/10/02 20:01:23]

It seems counter-intuitive to have a macro called CAST_TO_INT64 that casts to a
32-bit integer type.

I'd prefer CAST_TO_V8_INTEGER_VALUE (since it seems it casts to the return type
of Integer::Value).

I'd prefer C++ style casts, i.e., static_cast<int>(x).

+#else
+# define CAST_TO_INT64(x) (int64_t(x))
+#endif
+
 THREADED_TEST(TinyInteger) {
   v8::HandleScope scope;
   LocalContext env;
   int32_t value = 239;
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(BigSmiInteger) {
   v8::HandleScope scope;
   LocalContext env;
   int32_t value = (1 << 30) - 1;
   CHECK(i::Smi::IsValid(value));
   CHECK(!i::Smi::IsValid(value + 1));
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(BigInteger) {
   v8::HandleScope scope;
   LocalContext env;
   int32_t value = (1 << 30) + 1;
   CHECK(!i::Smi::IsValid(value));
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(TinyUnsignedInteger) {
   v8::HandleScope scope;
   LocalContext env;
   uint32_t value = 239;
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(BigUnsignedSmiInteger) {
   v8::HandleScope scope;
   LocalContext env;
   uint32_t value = (1 << 30) - 1;
   CHECK(i::Smi::IsValid(value));
   CHECK(!i::Smi::IsValid(value + 1));
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(BigUnsignedInteger) {
   v8::HandleScope scope;
   LocalContext env;
   uint32_t value = (1 << 30) + 1;
   CHECK(!i::Smi::IsValid(value));
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(OutOfSignedRangeUnsignedInteger) {
   v8::HandleScope scope;
   LocalContext env;
   uint32_t value = uint32_t(0xffffffff);
   Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_EQ(int64_t(value), value_obj->Value());
+  CHECK_EQ(CAST_TO_INT64(value), value_obj->Value());
 }
 
 
 THREADED_TEST(Number) {
   v8::HandleScope scope;
   LocalContext env;
   double PI = 3.1415926;
   Local<v8::Number> pi_obj = v8::Number::New(PI);
   CHECK_EQ(PI, pi_obj->NumberValue());
 }
@@ skipping 7274 matching lines @@
     env->Global()->Set(v8_str("get_stack_limit"), fun);
     CompileRun("get_stack_limit();");
 
     CHECK(stack_limit == set_limit);
   }
   {
     v8::Locker locker;
     CHECK(stack_limit == set_limit);
   }
 }