Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5682)

Unified Diff: chrome/browser/thumbnail_store.cc

Issue 255081: Coverity: Allocate |cache| after we have a logic path where we can return and... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/thumbnail_store.cc
===================================================================
--- chrome/browser/thumbnail_store.cc (revision 28032)
+++ chrome/browser/thumbnail_store.cc (working copy)
@@ -370,13 +370,12 @@
}
void ThumbnailStore::GetAllThumbnailsFromDisk(MessageLoop* cb_loop) {
- Cache* cache = new Cache;
-
sql::Statement statement(db_.GetCachedStatement(SQL_FROM_HERE,
"SELECT * FROM thumbnails"));
if (!statement)
return;
+ Cache* cache = new Cache;
while (statement.Step()) {
// The URL
GURL url(statement.ColumnString(0));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698