Coverity: Allocate |cache| after we have a logic path where we can return and...

chrome/browser/thumbnail_store.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/thumbnail_store.h"
 
 #include <string.h>
 #include <algorithm>
 
 #include "app/gfx/codec/jpeg_codec.h"
@@ skipping 352 matching lines @@
           "time_taken INTEGER DEFAULT 0,"
           "data BLOB)"))
       return;
   }
 
   if (cb_loop)
     GetAllThumbnailsFromDisk(cb_loop);
 }
 
 void ThumbnailStore::GetAllThumbnailsFromDisk(MessageLoop* cb_loop) {
-  Cache* cache = new Cache;
-
   sql::Statement statement(db_.GetCachedStatement(SQL_FROM_HERE,
       "SELECT * FROM thumbnails"));
   if (!statement)
     return;
 
+  Cache* cache = new Cache;
   while (statement.Step()) {
     // The URL
     GURL url(statement.ColumnString(0));
 
     // The score.
     ThumbnailScore score(statement.ColumnDouble(1),      // Boring score
                          statement.ColumnBool(2),        // Good clipping
                          statement.ColumnBool(3),        // At top
                          base::Time::FromInternalValue(
                             statement.ColumnInt64(4)));  // Time taken
@@ skipping 35 matching lines @@
 
 std::wstring ThumbnailStore::GetDictionaryKeyForURL(
     const std::string& url) const {
   return ASCIIToWide(MD5String(url));
 }
 
 bool ThumbnailStore::IsPopular(const GURL& url) const {
   return most_visited_urls_->size() < kMaxCacheSize ||
          most_visited_urls_->find(url) != most_visited_urls_->end();
 }