Issue 255062: Pass the renderer a11y flag to Chrome Frame-created renderers....

Issue 255062: Pass the renderer a11y flag to Chrome Frame-created renderers.... (Closed)

Created:
11 years, 2 months ago by slightlyoff

Modified:
9 years, 7 months ago

Reviewers:
iyengar, amit

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Pass the renderer a11y flag to Chrome Frame-created renderers. BUG=23669 TEST=watch event32 a11y event log on pages which render in GCF. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28081

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome_frame/chrome_frame_automation.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome_frame/chrome_launcher.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

amit

The CL itself looks good, however, there's an old bug regarding crashes when accessibility is ...

11 years, 2 months ago (2009-10-02 19:49:41 UTC) #2

slightlyoff

I'm not sure that it's fixed. Jonas? On Fri, Oct 2, 2009 at 12:49 PM, ...

11 years, 2 months ago (2009-10-02 21:42:44 UTC) #3

slightlyoff

Looking at the referenced bug more, it looks fixed. On Fri, Oct 2, 2009 at ...

11 years, 2 months ago (2009-10-03 00:46:29 UTC) #4

amit

On Fri, Oct 2, 2009 at 5:46 PM, Alex Russell <slightlyoff@chromium.org>wrote: > Looking at the ...

11 years, 2 months ago (2009-10-03 05:49:00 UTC) #5

Jonas Klink (Google)

The only reason the flag is still there is that it is still causing crashes ...

11 years, 2 months ago (2009-10-05 18:03:57 UTC) #6

slightlyoff

I'm fine with tablet crashes. We'll add it to the public "known issues". The a11y ...

11 years, 2 months ago (2009-10-05 19:25:28 UTC) #7

amit

11 years, 2 months ago (2009-10-05 19:53:37 UTC) #8

LGTM

On Mon, Oct 5, 2009 at 12:25 PM, Alex Russell <slightlyoff@chromium.org>wrote:

> I'm fine with tablet crashes. We'll add it to the public "known
> issues". The a11y win is worth it.
>
> Out of morbid curiosity, aren't most other a11y-using apps affected by
> similar issues on Vista/tablet?
>
> On Mon, Oct 5, 2009 at 11:03 AM, Jonas Klink (Google)
> <klink@chromium.org> wrote:
> > The only reason the flag is still there is that it is still causing
> crashes
> > on Tablet PCs, since Windows Vista for Tablet PCs is doing some hackery
> to
> > track the cursor by (incorrectly) using MSAA. When you turn on this
> switch,
> > I would monitor carefully for any crashes, especially on Tablet PCs.
> >
> > Otherwise, this CL LGTM.
> >
> > On Fri, Oct 2, 2009 at 10:48 PM, Amit Joshi <amit@chromium.org> wrote:
> >>
> >> On Fri, Oct 2, 2009 at 5:46 PM, Alex Russell <slightlyoff@chromium.org>
> >> wrote:
> >>>
> >>> Looking at the referenced bug more, it looks fixed.
> >>
> >> Right, I noticed several checkins. Since it is still behind a flag, just
> >> wanted to make sure that there are no known issues.
> >>>
> >>> On Fri, Oct 2, 2009 at 2:42 PM, Alex Russell <slightlyoff@chromium.org
> >
> >>> wrote:
> >>> > I'm not sure that it's fixed. Jonas?
> >>> >
> >>> > On Fri, Oct 2, 2009 at 12:49 PM,  <amit@chromium.org> wrote:
> >>> >> The CL itself looks good, however, there's an old bug regarding
> >>> >> crashes when
> >>> >> accessibility is turned on: http://b/issue?id=1432077
> >>> >> Are we sure that it's fixed and it's OK to turn on accessibility
> now?
> >>> >>
> >>> >> http://codereview.chromium.org/255062
> >>> >>
> >>> >
> >>
> >
> >
>

Expand Messages | Collapse Messages