Issue 252002: Coverity: initialize created_theme_provider_ in the other constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252002: Coverity: initialize created_theme_provider_ in the other constructor. (Closed)

Created:
11 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Coverity: initialize created_theme_provider_ in the other constructor. CID=6160 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27245

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/test/testing_profile.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 3 months ago (2009-09-25 19:58:39 UTC) #2

LGTM

On Fri, Sep 25, 2009 at 12:56 PM,  <mattm@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Coverity: initialize created_theme_provider_ in the other constructor.
>
> CID=3D6160
> BUG=3Dnone
> TEST=3Dnone
>
> Please review this at http://codereview.chromium.org/252002
>
> Affected files:
> =A0M chrome/test/testing_profile.cc
>
>
> Index: chrome/test/testing_profile.cc
> diff --git a/chrome/test/testing_profile.cc b/chrome/test/testing_profile=
.cc
> index
> 2f417cfe9550a4f7f7f98b7503d3b9c1cd6b7936..1eb312d06b8970640ad9b7e580bb73a=
d7897ce4a
> 100644
> --- a/chrome/test/testing_profile.cc
> +++ b/chrome/test/testing_profile.cc
> @@ -87,6 +87,7 @@ TestingProfile::TestingProfile()
>
> =A0TestingProfile::TestingProfile(int count)
> =A0 =A0 : start_time_(Time::Now()),
> + =A0 =A0 =A0created_theme_provider_(false),
> =A0 =A0 =A0 has_history_service_(false),
> =A0 =A0 =A0 off_the_record_(false),
> =A0 =A0 =A0 last_session_exited_cleanly_(true) {
>
>
>

Expand Messages | Collapse Messages