Issue 251091: Mac: Eliminate unintended "menu" method overrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251091: Mac: Eliminate unintended "menu" method overrides. (Closed)

Created:
11 years, 2 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Eliminate unintended "menu" method overrides. This had the bad effect of showing bad/strange menus upon right-click on various buttons or, worse, crashing. BUG=22148, 23606 TEST=Right click on back/forwards buttons (after some navigation so that they're active), page/wrench buttons, and bookmark bar off-the-side button and make sure no menu is shown (and it that it doesn't crash). Also do so when the menu is active/highlighted with menu already showing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28064

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -591 lines)			Patch
M	chrome/app/nibs/BookmarkBar.xib	View	25 chunks	+48 lines, -521 lines	0 comments	Download
M	chrome/app/nibs/Toolbar.xib	View	9 chunks	+21 lines, -17 lines	0 comments	Download
M	chrome/browser/cocoa/back_forward_menu_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/back_forward_menu_controller.mm	View	2 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/delayedmenu_button.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/delayedmenu_button.mm	View	5 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/cocoa/delayedmenu_button_unittest.mm	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/cocoa/menu_button.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/menu_button.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/menu_button_unittest.mm	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

11 years, 2 months ago (2009-10-05 20:00:24 UTC) #2

lgtm

odd you were able to repro this so easily when i couldn't.

Expand Messages | Collapse Messages