Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/cocoa/menu_button_unittest.mm

Issue 251091: Mac: Eliminate unintended "menu" method overrides. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/menu_button.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/menu_button_unittest.mm
diff --git a/chrome/browser/cocoa/menu_button_unittest.mm b/chrome/browser/cocoa/menu_button_unittest.mm
index 1861974248c8dfe7c5243cf62566419248ad1b8b..321a3bb43f69536caebcbe9dde9546c53d80b850 100644
--- a/chrome/browser/cocoa/menu_button_unittest.mm
+++ b/chrome/browser/cocoa/menu_button_unittest.mm
@@ -51,14 +51,14 @@ TEST_F(MenuButtonTest, MenuAssign) {
[menu insertItemWithTitle:@"bar" action:nil keyEquivalent:@"" atIndex:2];
[menu insertItemWithTitle:@"baz" action:nil keyEquivalent:@"" atIndex:3];
- [button_ setMenu:menu];
- EXPECT_TRUE([button_ menu]);
+ [button_ setAttachedMenu:menu];
+ EXPECT_TRUE([button_ attachedMenu]);
// TODO(viettrungluu): Display the menu. (The tough part is closing the menu,
// not opening it!)
// Since |button_| doesn't retain menu, we should probably unset it here.
- [button_ setMenu:nil];
+ [button_ setAttachedMenu:nil];
}
} // namespace
« no previous file with comments | « chrome/browser/cocoa/menu_button.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698