Issue 249021: gclient: fix to support reading .gclient_entries in old list format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249021: gclient: fix to support reading .gclient_entries in old list format (Closed)

Created:
11 years, 2 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

gclient: fix to support reading .gclient_entries in old list format Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27386

Patch Set 2 : use isinstanceof #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	gclient.py	View	1	1 chunk	+11 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/249021/diff/2001/3001 File gclient.py (right): http://codereview.chromium.org/249021/diff/2001/3001#newcode750 Line 750: if isinstance(prev_entries,list): if isinstance(prev_entries, list):

11 years, 2 months ago (2009-09-28 18:49:08 UTC) #2

levin

I really don't understand this code well enough to review it so don't expect anything ...

11 years, 2 months ago (2009-09-28 20:37:24 UTC) #3

msb

11 years, 2 months ago (2009-09-28 21:23:39 UTC) #4

levin@chromium.org (levin@chromium.org) wrote:
> I really don't understand this code well enough to review it so don't expect
> anything from me on this one.
>

No worries. maruel reviewed. The code was commited and the bug is now fixe.

>
> http://codereview.chromium.org/249021

Expand Messages | Collapse Messages

Issue 249021: gclient: fix to support reading .gclient_entries in old list format (Closed)

Description

Patch Set 1 #

Patch Set 2 : use isinstanceof #

Messages